Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: content/test/test_render_view_host.h

Issue 1713473002: Make TestRenderWidgetHostView::Show/Hide call through to RWHI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@crash
Patch Set: Update web_contents_impl_unittest.cc Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/test_render_view_host.h
diff --git a/content/test/test_render_view_host.h b/content/test/test_render_view_host.h
index 0cb0913bfaefea35b8e0698d9d88ea0a90e585ae..356c49ce0dd9fc216d5f1052514d4b9241666011 100644
--- a/content/test/test_render_view_host.h
+++ b/content/test/test_render_view_host.h
@@ -55,8 +55,7 @@ void InitNavigateParams(FrameHostMsg_DidCommitProvisionalLoad_Params* params,
// TestRenderViewHostView ------------------------------------------------------
-// Subclass the RenderViewHost's view so that we can call Show(), etc.,
-// without having side-effects.
+// Subclass the RenderViewHost's view.
class TestRenderWidgetHostView : public RenderWidgetHostViewBase {
public:
explicit TestRenderWidgetHostView(RenderWidgetHost* rwh);
@@ -143,7 +142,6 @@ class TestRenderWidgetHostView : public RenderWidgetHostViewBase {
gfx::NativeViewId GetParentForWindowlessPlugin() const override;
#endif
- bool is_showing() const { return is_showing_; }
bool is_occluded() const { return is_occluded_; }
bool did_swap_compositor_frame() const { return did_swap_compositor_frame_; }
@@ -151,7 +149,6 @@ class TestRenderWidgetHostView : public RenderWidgetHostViewBase {
RenderWidgetHostImpl* rwh_;
private:
- bool is_showing_;
bool is_occluded_;
bool did_swap_compositor_frame_;
ui::DummyTextInputClient text_input_client_;

Powered by Google App Engine
This is Rietveld 408576698