Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 171343003: Use compositor for page popups. (Closed)

Created:
6 years, 10 months ago by jbauman
Modified:
6 years, 10 months ago
Reviewers:
jamesr
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use compositor for page popups. This is essentially the last user of the legacy 2d path. BUG=271140 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167552

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
M Source/web/WebPagePopupImpl.h View 5 chunks +13 lines, -0 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 4 chunks +87 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
jbauman
6 years, 10 months ago (2014-02-20 21:31:43 UTC) #1
jamesr
These popups don't need the dynamic enter/leave force compositing mode stuff - that's basically there ...
6 years, 10 months ago (2014-02-20 22:00:33 UTC) #2
jbauman
On 2014/02/20 22:00:33, jamesr wrote: > These popups don't need the dynamic enter/leave force compositing ...
6 years, 10 months ago (2014-02-20 22:12:31 UTC) #3
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 10 months ago (2014-02-20 23:30:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/171343003/1
6 years, 10 months ago (2014-02-20 23:31:26 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 00:46:37 UTC) #6
Message was sent while issue was closed.
Change committed as 167552

Powered by Google App Engine
This is Rietveld 408576698