Use compositor for page popups.

Use compositor for page popups.

This is essentially the last user of the legacy 2d path.

BUG=271140
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167552

[jamesr, 2014-02-20 22:00:33]

These popups don't need the dynamic enter/leave force compositing mode stuff -
that's basically there for single threaded on-demand composited performance
only. but we don't have to kill that just yet

lgtm

https://codereview.chromium.org/171343003/diff/1/Source/web/WebPagePopupImpl.cpp
File Source/web/WebPagePopupImpl.cpp (right):

https://codereview.chromium.org/171343003/diff/1/Source/web/WebPagePopupImpl....
Source/web/WebPagePopupImpl.cpp:276:
m_layerTreeView->setDeviceScaleFactor(m_widgetClient->deviceScaleFactor());
apparently we don't have a way to update the device scale for WebWidgets that
aren't WebViews. i really doubt that's desired, but whatevs

[jbauman, 2014-02-20 22:12:31]

On 2014/02/20 22:00:33, jamesr wrote:
> These popups don't need the dynamic enter/leave force compositing mode stuff -
> that's basically there for single threaded on-demand composited performance
> only. but we don't have to kill that just yet

I'll at least need to leave in the dynamic enter force compositing mode, so that
we're not doing compositing here in the few cases where force compositing mode
is disabled (until we've killed GTK for good). It looks like the code never will
try to leave force compositing mode, though.
> 
> lgtm
> 
>
https://codereview.chromium.org/171343003/diff/1/Source/web/WebPagePopupImpl.cpp
> File Source/web/WebPagePopupImpl.cpp (right):
> 
>
https://codereview.chromium.org/171343003/diff/1/Source/web/WebPagePopupImpl....
> Source/web/WebPagePopupImpl.cpp:276:
> m_layerTreeView->setDeviceScaleFactor(m_widgetClient->deviceScaleFactor());
> apparently we don't have a way to update the device scale for WebWidgets that
> aren't WebViews. i really doubt that's desired, but whatevs

[jbauman, 2014-02-20 23:30:59]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-02-20 23:31:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/171343003/1

[commit-bot: I haz the power, 2014-02-21 00:46:37]

Change committed as 167552