Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1713383002: fix misc asserts and checks found by fuzzer (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -42 lines) Patch
M include/core/SkPathEffect.h View 2 chunks +14 lines, -2 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 2 chunks +1 line, -5 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 3 chunks +3 lines, -4 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 2 chunks +32 lines, -28 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713383002/1
4 years, 10 months ago (2016-02-20 21:56:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713383002/1
4 years, 10 months ago (2016-02-20 21:59:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/00bea4ad310c4ec4dd95809b47ce3fbfa8fd0e1e
4 years, 10 months ago (2016-02-20 22:18:32 UTC) #10
reed1
4 years, 10 months ago (2016-02-21 18:27:37 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1713413002/ by reed@google.com.

The reason for reverting is: speculative deps-roll fix.

Powered by Google App Engine
This is Rietveld 408576698