GN support for generating VS2013 project files

GN support for generating VS2013 project files

Optional Visual Studio version can now be specified for "gn gen".
The default remains Visual Studio 2015.

BUG=

Committed: https://crrev.com/d0bc0fa329d753da4fb333c572361f575411b8a7
Cr-Commit-Position: refs/heads/master@{#376849}

[NGG, 2016-02-20 17:12:08]

Description was changed from

==========
GN support for generating VS2013 project files

Optional Visual Studio version can now be specified for "gn gen".
The default remains Visual Studio 2015.

BUG=
==========

to

==========
GN support for generating VS2013 project files

Optional Visual Studio version can now be specified for "gn gen".
The default remains Visual Studio 2015.

BUG=
==========

[NGG, 2016-02-20 17:12:08]

ngg@ngg.hu changed reviewers:
+ brettw@chromium.org, tmoniuszko@opera.com

[Tomasz Moniuszko, 2016-02-22 09:30:37]

I though original solution works also with VS 2013 (although I haven't tested it
much).

Anyway it looks OK to me.

https://codereview.chromium.org/1713363002/diff/1/tools/gn/command_gen.cc
File tools/gn/command_gen.cc (right):

https://codereview.chromium.org/1713363002/diff/1/tools/gn/command_gen.cc#new...
tools/gn/command_gen.cc:178: } else if (ide == kSwitchIdeValueVs || ide ==
kSwitchIdeValueVs2015) {
I think this block can be merged with the previous one. Conditional operator may
be used for VS version and version number may be removed from output string (it
doesn't bring much information anyway).

https://codereview.chromium.org/1713363002/diff/1/tools/gn/command_gen.cc#new...
tools/gn/command_gen.cc:216: "        'vs2015' - Generate files for Visual
Studio 2015. (default)\n"
I think it's not clear what (default) means here. Also indentation is wrong. How
about this:
'vs' - Visual Studio project/solution files (default VS version - 2015).
'vs2013' - Visual Studio 2013 project/solution files.
'vs2015' - Visual Studio 2015 project/solution files.

[NGG, 2016-02-22 12:08:03]

https://codereview.chromium.org/1713363002/diff/1/tools/gn/command_gen.cc
File tools/gn/command_gen.cc (right):

https://codereview.chromium.org/1713363002/diff/1/tools/gn/command_gen.cc#new...
tools/gn/command_gen.cc:178: } else if (ide == kSwitchIdeValueVs || ide ==
kSwitchIdeValueVs2015) {
On 2016/02/22 09:30:37, Tomasz Moniuszko wrote:
> I think this block can be merged with the previous one. Conditional operator
may
> be used for VS version and version number may be removed from output string
(it
> doesn't bring much information anyway).

Done.

https://codereview.chromium.org/1713363002/diff/1/tools/gn/command_gen.cc#new...
tools/gn/command_gen.cc:216: "        'vs2015' - Generate files for Visual
Studio 2015. (default)\n"
On 2016/02/22 09:30:37, Tomasz Moniuszko wrote:
> I think it's not clear what (default) means here. Also indentation is wrong.
How
> about this:
> 'vs' - Visual Studio project/solution files (default VS version - 2015).
> 'vs2013' - Visual Studio 2013 project/solution files.
> 'vs2015' - Visual Studio 2015 project/solution files.

That's a too long line unfortunately, how about patch set 2?

[Tomasz Moniuszko, 2016-02-22 12:56:15]

On 2016/02/22 12:08:03, NGG wrote:

> On 2016/02/22 09:30:37, Tomasz Moniuszko wrote:
> > I think it's not clear what (default) means here. Also indentation is wrong.
> How
> > about this:
> > 'vs' - Visual Studio project/solution files (default VS version - 2015).
> > 'vs2013' - Visual Studio 2013 project/solution files.
> > 'vs2015' - Visual Studio 2015 project/solution files.
> 
> That's a too long line unfortunately, how about patch set 2?

LGTM but it still needs acceptance from brettw who is the owner here.

[brettw, 2016-02-22 21:41:51]

lgtm

[NGG, 2016-02-22 22:22:34]

The CQ bit was checked by ngg@ngg.hu

[commit-bot: I haz the power, 2016-02-22 22:24:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713363002/20001

[commit-bot: I haz the power, 2016-02-22 23:18:56]

Description was changed from

==========
GN support for generating VS2013 project files

Optional Visual Studio version can now be specified for "gn gen".
The default remains Visual Studio 2015.

BUG=
==========

to

==========
GN support for generating VS2013 project files

Optional Visual Studio version can now be specified for "gn gen".
The default remains Visual Studio 2015.

BUG=
==========

[commit-bot: I haz the power, 2016-02-22 23:18:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-22 23:20:06]

Description was changed from

==========
GN support for generating VS2013 project files

Optional Visual Studio version can now be specified for "gn gen".
The default remains Visual Studio 2015.

BUG=
==========

to

==========
GN support for generating VS2013 project files

Optional Visual Studio version can now be specified for "gn gen".
The default remains Visual Studio 2015.

BUG=

Committed: https://crrev.com/d0bc0fa329d753da4fb333c572361f575411b8a7
Cr-Commit-Position: refs/heads/master@{#376849}
==========

[commit-bot: I haz the power, 2016-02-22 23:20:07]

Patchset 2 (id:??) landed as
https://crrev.com/d0bc0fa329d753da4fb333c572361f575411b8a7
Cr-Commit-Position: refs/heads/master@{#376849}