Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index 0e76e792dbb30aaccaf53f36c9890a4f4471c85f..709f182670f4b087e58f7981d2073fd7d361e85d 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -118,13 +118,13 @@ void FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld(DOMWrapperWorld*
m_webFrame->client()->didClearWindowObject(m_webFrame, world->worldId());
Document* document = m_webFrame->frame()->document();
if (document) {
- WheelController::from(document);
+ WheelController::from(*document);
if (RuntimeEnabledFeatures::deviceMotionEnabled())
- DeviceMotionController::from(document);
+ DeviceMotionController::from(*document);
if (RuntimeEnabledFeatures::deviceOrientationEnabled())
- DeviceOrientationController::from(document);
+ DeviceOrientationController::from(*document);
if (RuntimeEnabledFeatures::screenOrientationEnabled())
- ScreenOrientationController::from(document);
+ ScreenOrientationController::from(*document);
}
}
}
@@ -507,7 +507,8 @@ void FrameLoaderClientImpl::postProgressFinishedNotification()
void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, NavigationPolicy policy, const String& suggestedName)
{
if (m_webFrame->client()) {
- DocumentFullscreen::webkitCancelFullScreen(m_webFrame->frame()->document());
+ ASSERT(m_webFrame->frame()->document());
+ DocumentFullscreen::webkitCancelFullScreen(*m_webFrame->frame()->document());
WrappedResourceRequest webreq(request);
m_webFrame->client()->loadURLExternally(
m_webFrame, webreq, static_cast<WebNavigationPolicy>(policy), suggestedName);

Powered by Google App Engine
This is Rietveld 408576698