Source/web/ChromeClientImpl.cpp - Issue 171333003: Pass implementation object to supplemental classes by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index 02981d26942d9e9f0e867f561dee83b2f6a51b3c..54af0ae072068f2a5d8708441fefc7dc68511066 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -223,7 +223,8 @@ Page* ChromeClientImpl::createWindow(Frame* frame, const FrameLoadRequest& r, co

if (policy == WebNavigationPolicyIgnore)

policy = getNavigationPolicy();

- DocumentFullscreen::webkitCancelFullScreen(frame->document());

+ ASSERT(frame->document());

+ DocumentFullscreen::webkitCancelFullScreen(*frame->document());

WebViewImpl* newView = toWebViewImpl(

m_webView->client()->createView(WebFrameImpl::fromFrame(frame), WrappedResourceRequest(r.resourceRequest()), features, r.frameName(), policy, shouldSendReferrer == NeverSendReferrer));

« Source/modules/screen_orientation/ScreenOrientation.cpp ('K') | « Source/platform/Supplementable.h ('k') | Source/web/ContextFeaturesClientImpl.cpp » ('j') | no next file with comments »