Source/modules/serviceworkers/NavigatorServiceWorker.h - Issue 171333003: Pass implementation object to supplemental classes by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/NavigatorServiceWorker.h

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/screen_orientation/ScreenOrientation.cpp ('K') | « Source/modules/screen_orientation/ScreenOrientationController.cpp ('k') | Source/modules/serviceworkers/NavigatorServiceWorker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/NavigatorServiceWorker.h

diff --git a/Source/modules/serviceworkers/NavigatorServiceWorker.h b/Source/modules/serviceworkers/NavigatorServiceWorker.h

index a1249e2c07815a250909b4f439ce75d9aae86018..67ac96503c467f32cde894fddbbc2aa5be65327f 100644

--- a/Source/modules/serviceworkers/NavigatorServiceWorker.h

+++ b/Source/modules/serviceworkers/NavigatorServiceWorker.h

@@ -17,14 +17,14 @@ class ServiceWorkerContainer;

class NavigatorServiceWorker FINAL : public Supplement<Navigator>, DOMWindowProperty {

public:

virtual ~NavigatorServiceWorker();

- static NavigatorServiceWorker* from(Navigator*);

- static NavigatorServiceWorker* toNavigatorServiceWorker(Navigator* navigator) { return static_cast<NavigatorServiceWorker*>(Supplement<Navigator>::from(navigator, supplementName())); }

+ static NavigatorServiceWorker& from(Navigator&);

+ static NavigatorServiceWorker* toNavigatorServiceWorker(Navigator& navigator) { return static_cast<NavigatorServiceWorker*>(Supplement<Navigator>::from(navigator, supplementName())); }

static const char* supplementName();

- static ServiceWorkerContainer* serviceWorker(Navigator*);

+ static ServiceWorkerContainer* serviceWorker(Navigator&);

private:

- explicit NavigatorServiceWorker(Navigator*);

+ explicit NavigatorServiceWorker(Navigator&);

ServiceWorkerContainer* serviceWorker();

RefPtr<ServiceWorkerContainer> m_serviceWorker;