Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Unified Diff: Source/modules/performance/SharedWorkerPerformance.cpp

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/performance/SharedWorkerPerformance.cpp
diff --git a/Source/modules/performance/SharedWorkerPerformance.cpp b/Source/modules/performance/SharedWorkerPerformance.cpp
index 559481f479b00b14c195b607ee8624a31b80e653..685ad227cdc7274bea28b0d2fdd93409a0aea36d 100644
--- a/Source/modules/performance/SharedWorkerPerformance.cpp
+++ b/Source/modules/performance/SharedWorkerPerformance.cpp
@@ -52,22 +52,22 @@ const char* SharedWorkerPerformance::supplementName()
return "SharedWorkerPerformance";
}
-SharedWorkerPerformance* SharedWorkerPerformance::from(SharedWorker* sharedWorker)
+SharedWorkerPerformance& SharedWorkerPerformance::from(SharedWorker& sharedWorker)
{
SharedWorkerPerformance* supplement = static_cast<SharedWorkerPerformance*>(Supplement<SharedWorker>::from(sharedWorker, supplementName()));
if (!supplement) {
supplement = new SharedWorkerPerformance();
provideTo(sharedWorker, supplementName(), adoptPtr(supplement));
}
- return supplement;
+ return *supplement;
}
-double SharedWorkerPerformance::workerStart(ExecutionContext* context, SharedWorker* sharedWorker)
+double SharedWorkerPerformance::workerStart(ExecutionContext* context, SharedWorker& sharedWorker)
{
- return SharedWorkerPerformance::from(sharedWorker)->getWorkerStart(context, sharedWorker);
+ return SharedWorkerPerformance::from(sharedWorker).getWorkerStart(context, sharedWorker);
}
-double SharedWorkerPerformance::getWorkerStart(ExecutionContext* context, SharedWorker* sharedWorker) const
+double SharedWorkerPerformance::getWorkerStart(ExecutionContext* context, SharedWorker&) const
{
ASSERT(context);
ASSERT(context->isDocument());

Powered by Google App Engine
This is Rietveld 408576698