Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: Source/modules/notifications/WorkerGlobalScopeNotifications.cpp

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/WorkerGlobalScopeNotifications.cpp
diff --git a/Source/modules/notifications/WorkerGlobalScopeNotifications.cpp b/Source/modules/notifications/WorkerGlobalScopeNotifications.cpp
index 20325ee5cded5c67674ec43efa574dc7ff83832b..d2627658a3aab35185eb56bb55debdbb94c8a18b 100644
--- a/Source/modules/notifications/WorkerGlobalScopeNotifications.cpp
+++ b/Source/modules/notifications/WorkerGlobalScopeNotifications.cpp
@@ -36,7 +36,7 @@
namespace WebCore {
-WorkerGlobalScopeNotifications::WorkerGlobalScopeNotifications(WorkerGlobalScope* context)
+WorkerGlobalScopeNotifications::WorkerGlobalScopeNotifications(WorkerGlobalScope& context)
: m_context(context)
{
}
@@ -50,25 +50,25 @@ const char* WorkerGlobalScopeNotifications::supplementName()
return "WorkerGlobalScopeNotifications";
}
-WorkerGlobalScopeNotifications* WorkerGlobalScopeNotifications::from(WorkerGlobalScope* context)
+WorkerGlobalScopeNotifications& WorkerGlobalScopeNotifications::from(WorkerGlobalScope& context)
{
WorkerGlobalScopeNotifications* supplement = static_cast<WorkerGlobalScopeNotifications*>(WorkerSupplement::from(context, supplementName()));
if (!supplement) {
supplement = new WorkerGlobalScopeNotifications(context);
WorkerSupplement::provideTo(context, supplementName(), adoptPtr(supplement));
}
- return supplement;
+ return *supplement;
}
-NotificationCenter* WorkerGlobalScopeNotifications::webkitNotifications(WorkerGlobalScope* context)
+NotificationCenter* WorkerGlobalScopeNotifications::webkitNotifications(WorkerGlobalScope& context)
{
- return WorkerGlobalScopeNotifications::from(context)->webkitNotifications();
+ return WorkerGlobalScopeNotifications::from(context).webkitNotifications();
}
NotificationCenter* WorkerGlobalScopeNotifications::webkitNotifications()
{
if (!m_notificationCenter)
- m_notificationCenter = NotificationCenter::create(m_context, m_context->thread()->getNotificationClient());
+ m_notificationCenter = NotificationCenter::create(&m_context, m_context.thread()->getNotificationClient());
return m_notificationCenter.get();
}

Powered by Google App Engine
This is Rietveld 408576698