Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: Source/modules/geolocation/GeolocationController.h

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeolocationController.h
diff --git a/Source/modules/geolocation/GeolocationController.h b/Source/modules/geolocation/GeolocationController.h
index d1c90812dde1db2fb79dbe31e0cf02c7dc8c6331..744880d7bff085ccbc9a640ca05ec7b970a920fd 100644
--- a/Source/modules/geolocation/GeolocationController.h
+++ b/Source/modules/geolocation/GeolocationController.h
@@ -47,7 +47,7 @@ class GeolocationController FINAL : public Supplement<Page>, public PageLifecycl
public:
virtual ~GeolocationController();
- static PassOwnPtr<GeolocationController> create(Page*, GeolocationClient*);
+ static PassOwnPtr<GeolocationController> create(Page&, GeolocationClient*);
void addObserver(Geolocation*, bool enableHighAccuracy);
void removeObserver(Geolocation*);
@@ -71,7 +71,7 @@ public:
static GeolocationController* from(Page* page) { return static_cast<GeolocationController*>(Supplement<Page>::from(page, supplementName())); }
private:
- GeolocationController(Page*, GeolocationClient*);
+ GeolocationController(Page&, GeolocationClient*);
void startUpdatingIfNeeded();
void stopUpdatingIfNeeded();

Powered by Google App Engine
This is Rietveld 408576698