Source/modules/device_orientation/DeviceOrientationInspectorAgent.h - Issue 171333003: Pass implementation object to supplemental classes by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationController.cpp ('k') | Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp » ('j') | Source/modules/screen_orientation/ScreenOrientation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

diff --git a/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h b/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

index 2918cf20f9af8fdb7213c7ec0b22fb16fea9ffd0..217e5e1aca83d5b99c33943015da407d8c1e8e42 100644

--- a/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

+++ b/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

@@ -17,7 +17,7 @@ typedef String ErrorString;

class DeviceOrientationInspectorAgent FINAL : public InspectorBaseAgent<DeviceOrientationInspectorAgent>, public InspectorBackendDispatcher::DeviceOrientationCommandHandler {

WTF_MAKE_NONCOPYABLE(DeviceOrientationInspectorAgent);

public:

- static void provideTo(Page*);

+ static void provideTo(Page&);

virtual ~DeviceOrientationInspectorAgent();

@@ -26,8 +26,8 @@ public:

virtual void clearDeviceOrientationOverride(ErrorString*) OVERRIDE;

private:

- explicit DeviceOrientationInspectorAgent(Page*);

- Page* m_page;

+ explicit DeviceOrientationInspectorAgent(Page&);

+ Page& m_page;

};

} // namespace WebCore