Source/core/inspector/InspectorDOMAgent.cpp - Issue 171333003: Pass implementation object to supplemental classes by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | Source/core/loader/PrerendererClient.h » ('j') | Source/modules/screen_orientation/ScreenOrientation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp

index da635a3d254504f7cdbcc57033d4b55b89edc949..c2f6d169cebdd921d0788d5e97f469c430685cde 100644

--- a/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/Source/core/inspector/InspectorDOMAgent.cpp

@@ -1007,8 +1007,9 @@ void InspectorDOMAgent::performSearch(ErrorString*, const String& whitespaceTrim

// XPath evaluation

for (Vector<Document*>::iterator it = docs.begin(); it != docs.end(); ++it) {

Document* document = *it;

+ ASSERT(document);

TrackExceptionState exceptionState;

- RefPtrWillBeRawPtr<XPathResult> result = DocumentXPathEvaluator::evaluate(document, whitespaceTrimmedQuery, document, 0, XPathResult::ORDERED_NODE_SNAPSHOT_TYPE, 0, exceptionState);

+ RefPtrWillBeRawPtr<XPathResult> result = DocumentXPathEvaluator::evaluate(*document, whitespaceTrimmedQuery, document, 0, XPathResult::ORDERED_NODE_SNAPSHOT_TYPE, 0, exceptionState);

if (exceptionState.hadException() || !result)

continue;