Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: Source/core/frame/NavigatorID.cpp

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/NavigatorID.cpp
diff --git a/Source/core/frame/NavigatorID.cpp b/Source/core/frame/NavigatorID.cpp
index 1b771dd148829c4b907d0f602e72e3cd072ffbd3..8a0def5c8f89c9bc29821317b63eb3d525d96718 100644
--- a/Source/core/frame/NavigatorID.cpp
+++ b/Source/core/frame/NavigatorID.cpp
@@ -45,24 +45,24 @@
namespace WebCore {
-String NavigatorID::appName(const NavigatorBase*)
+String NavigatorID::appName(const NavigatorBase&)
{
return "Netscape";
}
-String NavigatorID::appVersion(const NavigatorBase* navigator)
+String NavigatorID::appVersion(const NavigatorBase& navigator)
{
// Version is everything in the user agent string past the "Mozilla/" prefix.
- const String& agent = navigator->userAgent();
+ const String& agent = navigator.userAgent();
return agent.substring(agent.find('/') + 1);
}
-String NavigatorID::userAgent(const NavigatorBase* navigator)
+String NavigatorID::userAgent(const NavigatorBase& navigator)
{
- return navigator->userAgent();
+ return navigator.userAgent();
}
-String NavigatorID::platform(const NavigatorBase*)
+String NavigatorID::platform(const NavigatorBase&)
{
#if defined(WEBCORE_NAVIGATOR_PLATFORM)
return WEBCORE_NAVIGATOR_PLATFORM;
@@ -79,12 +79,12 @@ String NavigatorID::platform(const NavigatorBase*)
#endif
}
-String NavigatorID::appCodeName(const NavigatorBase*)
+String NavigatorID::appCodeName(const NavigatorBase&)
{
return "Mozilla";
}
-String NavigatorID::product(const NavigatorBase*)
+String NavigatorID::product(const NavigatorBase&)
{
return WEBCORE_NAVIGATOR_PRODUCT;
}

Powered by Google App Engine
This is Rietveld 408576698