Pass implementation object to supplemental classes by reference

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 281 matching lines @@
 void WebViewImpl::setDevToolsAgentClient(WebDevToolsAgentClient* devToolsClient)
 {
     if (devToolsClient)
         m_devToolsAgent = adoptPtr(new WebDevToolsAgentImpl(this, devToolsClient));
     else
         m_devToolsAgent.clear();
 }
 
 void WebViewImpl::setPrerendererClient(WebPrerendererClient* prerendererClient)
 {
-    providePrerendererClientTo(m_page.get(), new PrerendererClientImpl(prerendererClient));
+    ASSERT(m_page);
+    providePrerendererClientTo(*m_page, new PrerendererClientImpl(prerendererClient));
 }
 
 void WebViewImpl::setSpellCheckClient(WebSpellCheckClient* spellCheckClient)
 {
     m_spellCheckClient = spellCheckClient;
 }
 
 void WebViewImpl::setPasswordGeneratorClient(WebPasswordGeneratorClient* client)
 {
     m_passwordGeneratorClient = client;
@@ skipping 68 matching lines @@
     pageClients.chromeClient = &m_chromeClientImpl;
     pageClients.contextMenuClient = &m_contextMenuClientImpl;
     pageClients.editorClient = &m_editorClientImpl;
     pageClients.dragClient = &m_dragClientImpl;
     pageClients.inspectorClient = &m_inspectorClientImpl;
     pageClients.backForwardClient = &m_backForwardClientImpl;
     pageClients.spellCheckerClient = &m_spellCheckerClientImpl;
     pageClients.storageClient = &m_storageClientImpl;
 
     m_page = adoptPtr(new Page(pageClients));
-    provideUserMediaTo(m_page.get(), &m_userMediaClientImpl);
-    provideMIDITo(m_page.get(), m_midiClientProxy.get());
+    provideUserMediaTo(*m_page, &m_userMediaClientImpl);
+    provideMIDITo(*m_page, m_midiClientProxy.get());
 #if ENABLE(INPUT_SPEECH)
-    provideSpeechInputTo(m_page.get(), m_speechInputClient.get());
+    provideSpeechInputTo(*m_page, m_speechInputClient.get());
 #endif
-    provideSpeechRecognitionTo(m_page.get(), m_speechRecognitionClient.get());
-    provideNotification(m_page.get(), notificationPresenterImpl());
-    provideNavigatorContentUtilsTo(m_page.get(), m_navigatorContentUtilsClient.get());
+    provideSpeechRecognitionTo(*m_page, m_speechRecognitionClient.get());
+    provideNotification(*m_page, notificationPresenterImpl());
+    provideNavigatorContentUtilsTo(*m_page, m_navigatorContentUtilsClient.get());
 
-    provideContextFeaturesTo(m_page.get(), m_featureSwitchClient.get());
+    provideContextFeaturesTo(*m_page, m_featureSwitchClient.get());
     if (RuntimeEnabledFeatures::deviceOrientationEnabled())
-        DeviceOrientationInspectorAgent::provideTo(m_page.get());
-    provideGeolocationTo(m_page.get(), m_geolocationClientProxy.get());
+        DeviceOrientationInspectorAgent::provideTo(*m_page);
+    provideGeolocationTo(*m_page, m_geolocationClientProxy.get());
     m_geolocationClientProxy->setController(GeolocationController::from(m_page.get()));
 
-    provideLocalFileSystemTo(m_page.get(), LocalFileSystemClient::create());
-    provideDatabaseClientTo(m_page.get(), DatabaseClientImpl::create());
+    provideLocalFileSystemTo(*m_page, LocalFileSystemClient::create());
+    provideDatabaseClientTo(*m_page, DatabaseClientImpl::create());
     InspectorIndexedDBAgent::provideTo(m_page.get());
-    provideStorageQuotaClientTo(m_page.get(), StorageQuotaClientImpl::create());
+    provideStorageQuotaClientTo(*m_page, StorageQuotaClientImpl::create());
     m_validationMessage = ValidationMessageClientImpl::create(*this);
     m_page->setValidationMessageClient(m_validationMessage.get());
-    provideWorkerGlobalScopeProxyProviderTo(m_page.get(), WorkerGlobalScopeProxyProviderImpl::create());
+    provideWorkerGlobalScopeProxyProviderTo(*m_page, WorkerGlobalScopeProxyProviderImpl::create());
 
     m_page->setGroupType(Page::SharedPageGroup);
 
     if (m_client) {
         setDeviceScaleFactor(m_client->screenInfo().deviceScaleFactor);
         setVisibilityState(m_client->visibilityState(), true);
     }
 
     m_inspectorSettingsMap = adoptPtr(new SettingsMap);
 }
@@ skipping 977 matching lines @@
     if (!frame)
         return false;
 
     return frame->eventHandler().bubblingScroll(scrollDirection, scrollGranularity);
 }
 
 void WebViewImpl::popupOpened(PopupContainer* popupContainer)
 {
     ASSERT(!m_selectPopup);
     m_selectPopup = popupContainer;
-    Document* document = mainFrameImpl()->frame()->document();
+    ASSERT(mainFrameImpl()->frame()->document());
+    Document& document = *mainFrameImpl()->frame()->document();
     WheelController::from(document)->didAddWheelEventHandler(document);
 }
 
 void WebViewImpl::popupClosed(PopupContainer* popupContainer)
 {
     ASSERT(m_selectPopup);
     m_selectPopup = 0;
-    Document* document = mainFrameImpl()->frame()->document();
+    ASSERT(mainFrameImpl()->frame()->document());
+    Document& document = *mainFrameImpl()->frame()->document();
     WheelController::from(document)->didRemoveWheelEventHandler(document);
 }
 
 PagePopup* WebViewImpl::openPagePopup(PagePopupClient* client, const IntRect& originBoundsInRootView)
 {
     ASSERT(client);
     if (hasOpenedPopup())
         hidePopups();
     ASSERT(!m_pagePopup);
 
@@ skipping 2573 matching lines @@
     const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefinedConstraints();
 
     if (!mainFrameImpl() || !mainFrameImpl()->frameView())
         return false;
 
     return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
         || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 } // namespace blink