Source/modules/notifications/NotificationController.cpp - Issue 171333003: Pass implementation object to supplemental classes by reference

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/notifications/NotificationController.cpp

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/modules/notifications/NotificationController.h ('k') | Source/modules/notifications/WorkerGlobalScopeNotifications.h » ('j') | Source/modules/screen_orientation/ScreenOrientation.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Apple Inc. All rights reserved.	2 * Copyright (C) 2011 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 if (NotificationController* controller = NotificationController::from(page))	50 if (NotificationController* controller = NotificationController::from(page))

51 return controller->client();	51 return controller->client();

52 return 0;	52 return 0;

53 }	53 }

54	54

55 const char* NotificationController::supplementName()	55 const char* NotificationController::supplementName()

56 {	56 {

57 return "NotificationController";	57 return "NotificationController";

58 }	58 }

59	59

60 void provideNotification(Page* page, NotificationClient* client)	60 void provideNotification(Page& page, NotificationClient* client)

61 {	61 {

62 NotificationController::provideTo(page, NotificationController::supplementNa me(), NotificationController::create(client));	62 NotificationController::provideTo(page, NotificationController::supplementNa me(), NotificationController::create(client));

63 }	63 }

64	64

65 } // namespace WebCore	65 } // namespace WebCore

OLD	NEW