Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: Source/modules/filesystem/DataTransferItemFileSystem.cpp

Issue 171333003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 #include "modules/filesystem/DirectoryEntry.h" 41 #include "modules/filesystem/DirectoryEntry.h"
42 #include "modules/filesystem/DraggedIsolatedFileSystem.h" 42 #include "modules/filesystem/DraggedIsolatedFileSystem.h"
43 #include "modules/filesystem/Entry.h" 43 #include "modules/filesystem/Entry.h"
44 #include "modules/filesystem/FileEntry.h" 44 #include "modules/filesystem/FileEntry.h"
45 #include "platform/AsyncFileSystemCallbacks.h" 45 #include "platform/AsyncFileSystemCallbacks.h"
46 #include "platform/FileMetadata.h" 46 #include "platform/FileMetadata.h"
47 47
48 namespace WebCore { 48 namespace WebCore {
49 49
50 // static 50 // static
51 PassRefPtr<Entry> DataTransferItemFileSystem::webkitGetAsEntry(ExecutionContext* executionContext, DataTransferItem* item) 51 PassRefPtr<Entry> DataTransferItemFileSystem::webkitGetAsEntry(ExecutionContext* executionContext, DataTransferItem& item)
52 { 52 {
53 if (!item->dataObjectItem()->isFilename()) 53 if (!item.dataObjectItem()->isFilename())
54 return 0; 54 return 0;
55 55
56 // For dragged files getAsFile must be pretty lightweight. 56 // For dragged files getAsFile must be pretty lightweight.
57 Blob* file = item->getAsFile().get(); 57 Blob* file = item.getAsFile().get();
58 // The clipboard may not be in a readable state. 58 // The clipboard may not be in a readable state.
59 if (!file) 59 if (!file)
60 return 0; 60 return 0;
61 ASSERT(file->isFile()); 61 ASSERT(file->isFile());
62 62
63 DraggedIsolatedFileSystem* filesystem = DraggedIsolatedFileSystem::from(item ->clipboard()->dataObject().get()); 63 DraggedIsolatedFileSystem* filesystem = DraggedIsolatedFileSystem::from(item .clipboard()->dataObject().get());
64 DOMFileSystem* domFileSystem = filesystem ? filesystem->getDOMFileSystem(exe cutionContext) : 0; 64 DOMFileSystem* domFileSystem = filesystem ? filesystem->getDOMFileSystem(exe cutionContext) : 0;
65 if (!filesystem) { 65 if (!filesystem) {
66 // IsolatedFileSystem may not be enabled. 66 // IsolatedFileSystem may not be enabled.
67 return 0; 67 return 0;
68 } 68 }
69 69
70 ASSERT(domFileSystem); 70 ASSERT(domFileSystem);
71 71
72 // The dropped entries are mapped as top-level entries in the isolated files ystem. 72 // The dropped entries are mapped as top-level entries in the isolated files ystem.
73 String virtualPath = DOMFilePath::append("/", toFile(file)->name()); 73 String virtualPath = DOMFilePath::append("/", toFile(file)->name());
74 74
75 // FIXME: This involves synchronous file operation. Consider passing file ty pe data when we dispatch drag event. 75 // FIXME: This involves synchronous file operation. Consider passing file ty pe data when we dispatch drag event.
76 FileMetadata metadata; 76 FileMetadata metadata;
77 if (!getFileMetadata(toFile(file)->path(), metadata)) 77 if (!getFileMetadata(toFile(file)->path(), metadata))
78 return 0; 78 return 0;
79 79
80 if (metadata.type == FileMetadata::TypeDirectory) 80 if (metadata.type == FileMetadata::TypeDirectory)
81 return DirectoryEntry::create(domFileSystem, virtualPath); 81 return DirectoryEntry::create(domFileSystem, virtualPath);
82 return FileEntry::create(domFileSystem, virtualPath); 82 return FileEntry::create(domFileSystem, virtualPath);
83 } 83 }
84 84
85 } // namespace WebCore 85 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698