Pass implementation object to supplemental classes by reference

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 1592 matching lines @@
     }
 
     my $getterString;
     my ($functionName, @arguments) = GetterExpression($interfaceName, $attribute);
     push(@arguments, "isNull") if $isNullable;
     push(@arguments, "exceptionState") if $useExceptions;
     if ($attribute->extendedAttributes->{"ImplementedBy"}) {
         my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy"};
         my $implementedByImplName = GetImplNameFromImplementedBy($implementedBy);
         AddToImplIncludes(HeaderFilesForInterface($implementedBy, $implementedByImplName));
-        unshift(@arguments, "imp") if !$attribute->isStatic;
+        if (!$attribute->isStatic) {
+            $code .= "    ASSERT(imp);\n";
+            unshift(@arguments, "*imp");
+        }
         $functionName = "${implementedByImplName}::${functionName}";
     } elsif ($attribute->isStatic) {
         $functionName = "${implClassName}::${functionName}";
     } else {
         $functionName = "imp->${functionName}";
     }
     my ($arg, $subCode) = GenerateCallWith($attribute->extendedAttributes->{"CallWith"}, "    ", 0);
     $code .= $subCode;
     unshift(@arguments, @$arg);
     $getterString = "${functionName}(" . join(", ", @arguments) . ")";
@@ skipping 136 matching lines @@
 END
         }
     } elsif ($attribute->type eq "EventHandler") {
         AddToImplIncludes("bindings/v8/V8AbstractEventListener.h");
         # FIXME: Pass the main world ID for main-world-only getters.
         my ($functionName, @arguments) = GetterExpression($interfaceName, $attribute);
         my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy"};
         if ($implementedBy) {
             my $implementedByImplName = GetImplNameFromImplementedBy($implementedBy);
             $functionName = "${implementedByImplName}::${functionName}";
-            push(@arguments, "imp");
+            $code .= "    ASSERT(imp);\n";
+            push(@arguments, "*imp");
         } else {
             $functionName = "imp->${functionName}";
         }
         $code .= "    EventListener* jsValue = ${functionName}(" . join(", ", @arguments) . ");\n";
         $code .= "    v8SetReturnValue(info, jsValue ? v8::Handle<v8::Value>(V8AbstractEventListener::cast(jsValue)->getListenerObject(imp->executionContext())) : v8::Handle<v8::Value>(v8::Null(info.GetIsolate())));\n";
     } else {
         my $nativeValue = NativeToJSValue($attribute->type, $attribute->extendedAttributes, $expression, "    ", "", "info.GetIsolate()", "info", "imp", $forMainWorldSuffix, "return");
         $code .= "${nativeValue}\n";
     }
 
@@ skipping 330 matching lines @@
         my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy"};
         my $implementedByImplName;
         if ($implementedBy) {
             $implementedByImplName = GetImplNameFromImplementedBy($implementedBy);
         }
         if (!InheritsInterface($interface, "Node")) {
             my $attrImplName = GetImplName($attribute);
             my @arguments;
             if ($implementedBy) {
                 $attrImplName = "${implementedByImplName}::${attrImplName}";
-                push(@arguments, "imp");
+                $code .= "    ASSERT(imp);\n";
+                push(@arguments, "*imp");
             } else {
                 $attrImplName = "imp->${attrImplName}";
             }
             $code .= "    moveEventListenerToNewWrapper(info.Holder(), ${attrImplName}(" . join(", ", @arguments) . "), jsValue, ${v8ClassName}::eventListenerCacheIndex, info.GetIsolate());\n";
         }
         my ($functionName, @arguments) = SetterExpression($interfaceName, $attribute);
         if ($implementedBy) {
+            $code .= "    ASSERT(imp);\n";
             $functionName = "${implementedByImplName}::${functionName}";
-            push(@arguments, "imp");
+            push(@arguments, "*imp");
         } else {
             $functionName = "imp->${functionName}";
         }
         if (($interfaceName eq "Window" or $interfaceName eq "WorkerGlobalScope") and $attribute->name eq "onerror") {
             AddToImplIncludes("bindings/v8/V8ErrorHandler.h");
             push(@arguments, "V8EventListenerList::findOrCreateWrapper<V8ErrorHandler>(jsValue, true, info.GetIsolate())");
         } else {
             push(@arguments, "V8EventListenerList::getEventListener(jsValue, true, ListenerFindOrCreate)");
         }
         $code .= "    ${functionName}(" . join(", ", @arguments) . ");\n";
     } else {
         my ($functionName, @arguments) = SetterExpression($interfaceName, $attribute);
         push(@arguments, $expression);
         push(@arguments, "exceptionState") if $useExceptions;
         if ($attribute->extendedAttributes->{"ImplementedBy"}) {
             my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy"};
             my $implementedByImplName = GetImplNameFromImplementedBy($implementedBy);
             AddToImplIncludes(HeaderFilesForInterface($implementedBy, $implementedByImplName));
-            unshift(@arguments, "imp") if !$attribute->isStatic;
+            if (!$attribute->isStatic) {
+                $code .= "    ASSERT(imp);\n";
+                unshift(@arguments, "*imp");
+            }
             $functionName = "${implementedByImplName}::${functionName}";
         } elsif ($attribute->isStatic) {
             $functionName = "${implClassName}::${functionName}";
         } else {
             $functionName = "imp->${functionName}";
         }
         my ($arg, $subCode) = GenerateCallWith($attribute->extendedAttributes->{"SetterCallWith"} || $attribute->extendedAttributes->{"CallWith"}, "    ", 1);
         $code .= $subCode;
         unshift(@arguments, @$arg);
         $code .= "    ${functionName}(" . join(", ", @arguments) . ");\n";
@@ skipping 3124 matching lines @@
 
     my $index = 0;
     my $humanFriendlyIndex = $index + 1;
 
     my @arguments;
     my $functionName;
     my $implementedBy = $function->extendedAttributes->{"ImplementedBy"};
     if ($implementedBy) {
         my $implementedByImplName = GetImplNameFromImplementedBy($implementedBy);
         AddToImplIncludes(HeaderFilesForInterface($implementedBy, $implementedByImplName));
-        unshift(@arguments, "imp") if !$function->isStatic;
+        if (!$function->isStatic) {
+            $code .= "    ASSERT(imp);\n";
+            unshift(@arguments, "*imp");
+        }
         $functionName = "${implementedByImplName}::${name}";
     } elsif ($function->isStatic) {
         $functionName = "${implClassName}::${name}";
     } else {
         $functionName = "imp->${name}";
     }
 
     my $callWith = $function->extendedAttributes->{"CallWith"};
     my ($callWithArgs, $subCode) = GenerateCallWith($callWith, $indent, 1, $function);
     $code .= $subCode;
@@ skipping 1181 matching lines @@
         if ($parameter->type eq "SerializedScriptValue") {
             return 1;
         } elsif (IsIntegerType($parameter->type)) {
             return 1;
         }
     }
     return 0;
 }
 
 1;