Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Issue 1713283002: MD Settings: Manage search engines, polish to match latest mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extract_listener_behavior
Patch Set: remove paper-button dependency Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
index 509da5034d129376a458e1867d85ea4fc7f41352..de0384912d57e0a3cebc9be0e80e682ea68f3f72 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
@@ -1,9 +1,11 @@
<link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-dropdown.html">
+<link rel="import" href="chrome://md-settings/search_engines_page/search_engine_dialog.html">
<link rel="import" href="chrome://md-settings/search_engines_page/search_engines_browser_proxy.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-dropdown.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
-<link rel="import" href="chrome://md-settings/search_engines_page/search_engine_dialog.html">
<link rel="import" href="chrome://md-settings/settings_shared_css.html">
<dom-module id="settings-search-engine-entry">
@@ -17,13 +19,17 @@
<div id="container" class="list-item">
<div class="name-column">
<span class="icon-container">
- <iron-icon src="[[engine.iconURL]]"></iron-icon>
+ <template is="dom-if" if="[[engine.iconURL]]">
+ <iron-icon src="[[engine.iconURL]]"></iron-icon>
+ </template>
+ <template is="dom-if" if="[[!engine.iconURL]]">
+ <iron-icon icon="icons:find-in-page"></iron-icon>
+ </template>
</span>
- <div class="name">[[engine.displayName]]</div>
+ <span class="name">[[engine.displayName]]</span>
</div>
<div class="keyword-column">[[engine.keyword]]</div>
<div class="url-column">[[engine.url]]</div>
- <div class="icon-container">
<paper-icon-button icon="more-vert" toggles active="{{editMenuOpened}}">
</paper-icon-button>
<iron-dropdown opened="{{editMenuOpened}}" horizontal-align="right"
@@ -39,7 +45,6 @@
hidden="[[engine.default]]" id="delete"></paper-item>
<div>
</iron-dropdown>
- </div>
</div>
</template>
<script src="search_engine_entry.js"></script>

Powered by Google App Engine
This is Rietveld 408576698