Mojo C++ bindings: support sync methods - part 2

Mojo C++ bindings: support sync methods - part 2

This CL introduces the correct re-entrancy behavior: when a sync call is waiting
for response, allow incoming sync requests on the same thread to re-enter, async
messages are queued until the sync call completes.

The following will be in future CLs:
- Support sync calls with associated interfaces.

BUG=577699
Committed: https://crrev.com/083f46638041ba7d7620e47a7f9edf06982a9340
Cr-Commit-Position: refs/heads/master@{#376751}

[yzshen1, 2016-02-20 00:40:21]

yzshen@chromium.org changed reviewers:
+ jam@chromium.org

[yzshen1, 2016-02-20 00:40:22]

Hi, John.

Would you please take a look? Thanks!

[jam, 2016-02-20 02:02:05]

lgtm

https://codereview.chromium.org/1713203002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/lib/sync_handle_watcher.h (right):

https://codereview.chromium.org/1713203002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/lib/sync_handle_watcher.h:39: // Waits on all the
registered handles and runs callbacks synchrously for
nit: synchrously

[yzshen1, 2016-02-21 22:13:53]

Thanks!

https://codereview.chromium.org/1713203002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/lib/sync_handle_watcher.h (right):

https://codereview.chromium.org/1713203002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/lib/sync_handle_watcher.h:39: // Waits on all the
registered handles and runs callbacks synchrously for
On 2016/02/20 02:02:04, jam wrote:
> nit: synchrously 

Done.

[yzshen1, 2016-02-21 22:14:00]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-02-21 22:14:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1713203002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-02-21 22:14:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713203002/60001

[commit-bot: I haz the power, 2016-02-21 22:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-21 22:30:25]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[yzshen1, 2016-02-22 01:06:08]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-02-22 01:06:08]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1713203002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-02-22 01:06:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713203002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713203002/80001

[commit-bot: I haz the power, 2016-02-22 02:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 02:17:55]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2016-02-22 16:22:43]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-02-22 16:22:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1713203002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-02-22 16:23:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713203002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713203002/100001

[commit-bot: I haz the power, 2016-02-22 17:25:19]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-22 17:26:43]

Description was changed from

==========
Mojo C++ bindings: support sync methods - part 2

This CL introduces the correct re-entrancy behavior: when a sync call is waiting
for response, allow incoming sync requests on the same thread to re-enter, async
messages are queued until the sync call completes.

The following will be in future CLs:
- Support sync calls with associated interfaces.


BUG=577699
==========

to

==========
Mojo C++ bindings: support sync methods - part 2

This CL introduces the correct re-entrancy behavior: when a sync call is waiting
for response, allow incoming sync requests on the same thread to re-enter, async
messages are queued until the sync call completes.

The following will be in future CLs:
- Support sync calls with associated interfaces.

BUG=577699

Committed: https://crrev.com/083f46638041ba7d7620e47a7f9edf06982a9340
Cr-Commit-Position: refs/heads/master@{#376751}
==========

[commit-bot: I haz the power, 2016-02-22 17:26:44]

Patchset 6 (id:??) landed as
https://crrev.com/083f46638041ba7d7620e47a7f9edf06982a9340
Cr-Commit-Position: refs/heads/master@{#376751}

[Reilly Grant (use Gerrit), 2016-02-22 20:13:36]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1720093002/ by reillyg@chromium.org.

The reason for reverting is: This change is triggering a
use-of-uninitialized-value error on the Linux and Chrome OS MSan bots:

https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20....