third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp - Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp ('k') | third_party/WebKit/Source/platform/heap/HeapPage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp b/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

index 59c482c9733463128cc1df492f8fc8abb46940cc..60edb545378773813cac6f8cba1c360d8f554530 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

@@ -26,11 +26,11 @@

#include "platform/graphics/ImageFrameGenerator.h"

#include "platform/SharedBuffer.h"

-#include "platform/Task.h"

#include "platform/ThreadSafeFunctional.h"

#include "platform/graphics/ImageDecodingStore.h"

#include "platform/graphics/test/MockImageDecoder.h"

#include "public/platform/Platform.h"

+#include "public/platform/WebTaskRunner.h"

#include "public/platform/WebThread.h"

#include "public/platform/WebTraceLocation.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -198,7 +198,7 @@ TEST_F(ImageFrameGeneratorTest, incompleteDecodeBecomesCompleteMultiThreaded)

data = m_generator->refEncodedData();

EXPECT_EQ(nullptr, data);

OwnPtr<WebThread> thread = adoptPtr(Platform::current()->createThread("DecodeThread"));

- thread->taskRunner()->postTask(BLINK_FROM_HERE, new Task(threadSafeBind(&decodeThreadMain, AllowCrossThreadAccess(m_generator.get()))));

+ thread->taskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&decodeThreadMain, AllowCrossThreadAccess(m_generator.get())));

thread.clear();

EXPECT_EQ(2, m_decodeRequestCount);

EXPECT_EQ(1, m_decodersDestroyed);

@@ -215,7 +215,7 @@ TEST_F(ImageFrameGeneratorTest, incompleteDecodeBecomesCompleteMultiThreaded)

// Thread will also ref and unref the data.

thread = adoptPtr(Platform::current()->createThread("RefEncodedDataThread"));

- thread->taskRunner()->postTask(BLINK_FROM_HERE, new Task(threadSafeBind(&decodeThreadWithRefEncodedMain, AllowCrossThreadAccess(m_generator.get()))));

+ thread->taskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&decodeThreadWithRefEncodedMain, AllowCrossThreadAccess(m_generator.get())));

thread.clear();

EXPECT_EQ(4, m_decodeRequestCount);