third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp - Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h ('k') | third_party/WebKit/Source/platform/WebScheduler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp b/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

index 87d51bd78c9b6e2739d513e8a2c656fe9d4f6d92..9ee6e7e0ba7db05d78bdcb76e281a4ef9444f7cc 100644

--- a/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

@@ -66,7 +66,7 @@ void DatabaseThread::start()

if (m_thread)

return;

m_thread = WebThreadSupportingGC::create("WebCore: Database");

- m_thread->postTask(BLINK_FROM_HERE, new Task(threadSafeBind(&DatabaseThread::setupDatabaseThread, this)));

+ m_thread->postTask(BLINK_FROM_HERE, threadSafeBind(&DatabaseThread::setupDatabaseThread, this));

}

void DatabaseThread::setupDatabaseThread()

@@ -84,7 +84,7 @@ void DatabaseThread::terminate()

m_terminationRequested = true;

m_cleanupSync = &sync;

WTF_LOG(StorageAPI, "DatabaseThread %p was asked to terminate\n", this);

- m_thread->postTask(BLINK_FROM_HERE, new Task(threadSafeBind(&DatabaseThread::cleanupDatabaseThread, this)));

+ m_thread->postTask(BLINK_FROM_HERE, threadSafeBind(&DatabaseThread::cleanupDatabaseThread, this));

}

sync.waitForTaskCompletion();

// The WebThread destructor blocks until all the tasks of the database

@@ -112,7 +112,7 @@ void DatabaseThread::cleanupDatabaseThread()

}

m_openDatabaseSet.clear();

- m_thread->postTask(BLINK_FROM_HERE, new Task(WTF::bind(&DatabaseThread::cleanupDatabaseThreadCompleted, this)));

+ m_thread->postTask(BLINK_FROM_HERE, WTF::bind(&DatabaseThread::cleanupDatabaseThreadCompleted, this));

}

void DatabaseThread::cleanupDatabaseThreadCompleted()

@@ -170,7 +170,7 @@ void DatabaseThread::scheduleTask(PassOwnPtr<DatabaseTask> task)

}

#endif

// WebThread takes ownership of the task.

- m_thread->postTask(BLINK_FROM_HERE, new Task(threadSafeBind(&DatabaseTask::run, task)));

+ m_thread->postTask(BLINK_FROM_HERE, threadSafeBind(&DatabaseTask::run, task));

}

} // namespace blink