third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp - Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediacapturefromelement/TimedCanvasDrawListener.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp b/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

index 7da05aff7f1743077e69ede12a7448fa60a656e1..b01feaa14b605c8db58dc5c8784c104965f4423e 100644

--- a/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

@@ -27,7 +27,6 @@

#include "modules/webaudio/AbstractAudioContext.h"

#include "modules/webaudio/AudioBuffer.h"

#include "modules/webaudio/AudioBufferCallback.h"

-#include "platform/Task.h"

#include "platform/ThreadSafeFunctional.h"

#include "platform/audio/AudioBus.h"

#include "platform/audio/AudioFileReader.h"

@@ -58,7 +57,7 @@ void AsyncAudioDecoder::decodeAsync(DOMArrayBuffer* audioData, float sampleRate,

RefPtr<DOMArrayBuffer> audioDataRef(audioData);

// The leak references to successCallback and errorCallback are picked up on notifyComplete.

- m_thread->taskRunner()->postTask(BLINK_FROM_HERE, new Task(threadSafeBind(&AsyncAudioDecoder::decode, AllowCrossThreadAccess(audioDataRef.release().leakRef()), sampleRate, successCallback, errorCallback, resolver, context)));

+ m_thread->taskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&AsyncAudioDecoder::decode, AllowCrossThreadAccess(audioDataRef.release().leakRef()), sampleRate, successCallback, errorCallback, resolver, context));

}

void AsyncAudioDecoder::decode(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, ScriptPromiseResolver* resolver, AbstractAudioContext* context)

@@ -85,4 +84,3 @@ void AsyncAudioDecoder::notifyComplete(DOMArrayBuffer* audioData, AudioBufferCal

}

} // namespace blink