third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp - Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp

Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp ('k') | third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp b/third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp

index fb261c504f31cf1306427155a1c1e22c4968098e..e80ffd7ce032db9080bd725d087f7a99903134f2 100644

--- a/third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp

@@ -7,7 +7,6 @@

#include "core/testing/DummyPageHolder.h"

#include "core/testing/NullExecutionContext.h"

#include "modules/fetch/DataConsumerHandleTestUtil.h"

-#include "platform/Task.h"

#include "platform/ThreadSafeFunctional.h"

#include "platform/WaitableEvent.h"

#include "platform/WebThreadSupportingGC.h"

@@ -58,7 +57,7 @@ public:

{

m_thread = adoptPtr(new Thread("src thread", Thread::WithExecutionContext));

m_waitableEvent = adoptPtr(new WaitableEvent());

- m_thread->thread()->postTask(BLINK_FROM_HERE, new Task(threadSafeBind(&TeeCreationThread<Handle>::runInternal, AllowCrossThreadAccess(this), src, AllowCrossThreadAccess(dest1), AllowCrossThreadAccess(dest2))));

+ m_thread->thread()->postTask(BLINK_FROM_HERE, threadSafeBind(&TeeCreationThread<Handle>::runInternal, AllowCrossThreadAccess(this), src, AllowCrossThreadAccess(dest1), AllowCrossThreadAccess(dest2)));

m_waitableEvent->wait();

}

@@ -213,7 +212,7 @@ TEST(DataConsumerTeeTest, StopSource)

// We can pass a raw pointer because the subsequent |wait| calls ensure

// t->thread() is alive.

- t->thread()->thread()->postTask(BLINK_FROM_HERE, new Task(threadSafeBind(postStop, AllowCrossThreadAccess(t->thread()))));

+ t->thread()->thread()->postTask(BLINK_FROM_HERE, threadSafeBind(postStop, AllowCrossThreadAccess(t->thread())));

OwnPtr<HandleReadResult> res1 = r1.wait();

OwnPtr<HandleReadResult> res2 = r2.wait();