third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp - Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

Issue 1713143002: Remove most of the blink::Task wrapping of WTF::Function outside WebTaskRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

index e4654725c4d1aaf0faefa6c7d5f2267c29d8c01e..77379c26c9445e247859737837c260e59d6c033b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

@@ -14,7 +14,6 @@

#include "core/html/parser/TextResourceDecoder.h"

#include "platform/Histogram.h"

#include "platform/SharedBuffer.h"

-#include "platform/Task.h"

#include "platform/ThreadSafeFunctional.h"

#include "platform/TraceEvent.h"

#include "public/platform/WebScheduler.h"

@@ -546,7 +545,7 @@ void ScriptStreamer::notifyAppendData(ScriptResource* resource)

// running. This is taken care of with a manual ref() & deref() pair;

// the corresponding deref() is in streamingComplete.

ref();

- ScriptStreamerThread::shared()->postTask(new Task(threadSafeBind(&ScriptStreamerThread::runScriptStreamingTask, scriptStreamingTask.release(), AllowCrossThreadAccess(this))));

+ ScriptStreamerThread::shared()->postTask(threadSafeBind(&ScriptStreamerThread::runScriptStreamingTask, scriptStreamingTask.release(), AllowCrossThreadAccess(this)));

recordStartedStreamingHistogram(m_scriptType, 1);

}

if (m_stream)