Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1713083002: Fix inconsistency with LinkedReference.numTypeParameters (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix inconsistency with LinkedReference.numTypeParameters Sometimes it included parent type parameters, sometimes it did not. Now it consistently does not. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ce830bb3caddc0ccd788b1c486741b8c8883fa8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -6 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-19 17:19:03 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-19 17:24:02 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-19 17:25:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce830bb3caddc0ccd788b1c486741b8c8883fa8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698