Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1713033002: Ship Turbofan try-catch. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship Turbofan try-catch. Another attempt, after the failing test (flushed bug) has been disabled in chromium (https://codereview.chromium.org/1710353002). Committed: https://crrev.com/bd6ddb83409749425f6dc59a2200d259c44fb683 Cr-Commit-Position: refs/heads/master@{#34159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Second attempt, let's see how bad the perf implications are...
4 years, 10 months ago (2016-02-19 14:03:36 UTC) #2
Michael Starzinger
LGTM (rubber-stamped).
4 years, 10 months ago (2016-02-19 15:08:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713033002/1
4 years, 10 months ago (2016-02-19 15:19:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 15:20:42 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 15:20:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd6ddb83409749425f6dc59a2200d259c44fb683
Cr-Commit-Position: refs/heads/master@{#34159}

Powered by Google App Engine
This is Rietveld 408576698