chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java - Issue 1712943002: [Android] Simplify "network predictions" preference to a boolean value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

Issue 1712943002: [Android] Simplify "network predictions" preference to a boolean value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated TODO in prediction_options.h Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/xml/privacy_preferences.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java » ('j') | chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

index 117ae82217be3e2106621f818a582c0a3beefc76..360bae69d12d9b21d3234ad74b0e7c83fbc12871 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

@@ -11,7 +11,6 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.browser.ChromeVersionInfo;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchSelectionController.SelectionType;

import org.chromium.chrome.browser.preferences.ChromePreferenceManager;

-import org.chromium.chrome.browser.preferences.NetworkPredictionOptions;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

import org.chromium.content.browser.ContentViewCore;

@@ -99,8 +98,7 @@ class ContextualSearchPolicy {

* explicitly interacts with the feature.

boolean shouldPrefetchSearchResult(boolean isTapTriggered) {

- if (PrefServiceBridge.getInstance().getNetworkPredictionOptions()

- == NetworkPredictionOptions.NETWORK_PREDICTION_NEVER) {

+ if (!PrefServiceBridge.getInstance().getNetworkPredictionEnabled()) {

return false;

}