Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4120)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java

Issue 1712943002: [Android] Simplify "network predictions" preference to a boolean value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added bug link; rebased Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java
index 6ba20df81194a02396d790109cb8fb3d0d27a7a2..bbe0e365eee57ac08a01e85a391294d15c6bf216 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java
@@ -16,7 +16,6 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity;
-import org.chromium.chrome.browser.preferences.NetworkPredictionOptions;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.test.ChromeActivityTestCaseBase;
import org.chromium.chrome.test.util.InfoBarTestAnimationListener;
@@ -161,13 +160,12 @@ public class InfoBarContainerTest extends ChromeActivityTestCaseBase<ChromeActiv
}
// Define function to pass parameter to Runnable to be used in testInfoBarExpirationNoPrerender.
- private Runnable setNetworkPredictionOptions(
- final NetworkPredictionOptions networkPredictionOptions) {
+ private Runnable setNetworkPredictionOptions(final boolean networkPredictionEnabled) {
return new Runnable() {
@Override
public void run() {
- PrefServiceBridge.getInstance().setNetworkPredictionOptions(
- networkPredictionOptions);
+ PrefServiceBridge.getInstance().setNetworkPredictionEnabled(
+ networkPredictionEnabled);
}
};
}
@@ -176,26 +174,25 @@ public class InfoBarContainerTest extends ChromeActivityTestCaseBase<ChromeActiv
* Same as testInfoBarExpiration but with prerender turned-off.
* The behavior when prerender is on/off is different as in the prerender case the infobars are
* added when we swap tabs.
- * @throws InterruptedException
*/
@MediumTest
@Feature({"Browser"})
public void testInfoBarExpirationNoPrerender() throws Exception {
// Save prediction preference.
- NetworkPredictionOptions networkPredictionOption =
- ThreadUtils.runOnUiThreadBlocking(new Callable<NetworkPredictionOptions>() {
+ boolean networkPredictionEnabled =
+ ThreadUtils.runOnUiThreadBlocking(new Callable<Boolean>() {
@Override
- public NetworkPredictionOptions call() {
- return PrefServiceBridge.getInstance().getNetworkPredictionOptions();
+ public Boolean call() {
+ return PrefServiceBridge.getInstance().getNetworkPredictionEnabled();
}
});
try {
- ThreadUtils.runOnUiThreadBlocking(setNetworkPredictionOptions(
- NetworkPredictionOptions.NETWORK_PREDICTION_NEVER));
+ ThreadUtils.runOnUiThreadBlocking(setNetworkPredictionOptions(false));
testInfoBarExpiration();
} finally {
// Make sure we restore prediction preference.
- ThreadUtils.runOnUiThreadBlocking(setNetworkPredictionOptions(networkPredictionOption));
+ ThreadUtils.runOnUiThreadBlocking(
+ setNetworkPredictionOptions(networkPredictionEnabled));
}
}

Powered by Google App Engine
This is Rietveld 408576698