Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4511)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

Issue 1712943002: [Android] Simplify "network predictions" preference to a boolean value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added bug link; rebased Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
index fcacce2b0130ad4233ee0e238acb3ba784eafe70..13699c37e7d814af2b968478e621842c17e1cf1b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
@@ -516,40 +516,40 @@ public final class PrefServiceBridge {
/**
* @return whether there is a user set value for kNetworkPredictionEnabled. This should only be
- * used for preference migration.
+ * used for preference migration. See http://crbug.com/334602
*/
- public boolean networkPredictionEnabledHasUserSetting() {
- return nativeNetworkPredictionEnabledHasUserSetting();
+ public boolean obsoleteNetworkPredictionEnabledHasUserSetting() {
+ return nativeObsoleteNetworkPredictionEnabledHasUserSetting();
}
/**
* @return whether there is a user set value for kNetworkPredictionOptions. This should only be
- * used for preference migration.
+ * used for preference migration. See http://crbug.com/334602
*/
- public boolean networkPredictionOptionsHasUserSetting() {
- return nativeNetworkPredictionOptionsHasUserSetting();
+ public boolean obsoleteNetworkPredictionOptionsHasUserSetting() {
+ return nativeObsoleteNetworkPredictionOptionsHasUserSetting();
}
/**
* @return the user set value for kNetworkPredictionEnabled. This should only be used for
- * preference migration.
+ * preference migration. See http://crbug.com/334602
*/
- public boolean getNetworkPredictionEnabledUserPrefValue() {
- return nativeGetNetworkPredictionEnabledUserPrefValue();
+ public boolean obsoleteGetNetworkPredictionEnabledUserPrefValue() {
+ return nativeObsoleteGetNetworkPredictionEnabledUserPrefValue();
}
/**
* @return Network predictions preference.
*/
- public NetworkPredictionOptions getNetworkPredictionOptions() {
- return NetworkPredictionOptions.intToEnum(nativeGetNetworkPredictionOptions());
+ public boolean getNetworkPredictionEnabled() {
+ return nativeGetNetworkPredictionEnabled();
}
/**
* Sets network predictions preference.
*/
- public void setNetworkPredictionOptions(NetworkPredictionOptions option) {
- nativeSetNetworkPredictionOptions(option.enumToInt());
+ public void setNetworkPredictionEnabled(boolean enabled) {
+ nativeSetNetworkPredictionEnabled(enabled);
}
/**
@@ -564,8 +564,8 @@ public final class PrefServiceBridge {
* connection type.
* @return Whether network predictions are allowed.
*/
- public boolean canPredictNetworkActions() {
- return nativeCanPredictNetworkActions();
+ public boolean canPrefetchAndPrerender() {
+ return nativeCanPrefetchAndPrerender();
}
/**
@@ -1036,7 +1036,7 @@ public final class PrefServiceBridge {
private native void nativeSetPasswordEchoEnabled(boolean enabled);
private native void nativeSetPopupException(String pattern, int setting);
private native void nativeSetCrashReporting(boolean reporting);
- private native boolean nativeCanPredictNetworkActions();
+ private native boolean nativeCanPrefetchAndPrerender();
private native AboutVersionStrings nativeGetAboutVersionStrings();
private native void nativeSetContextualSearchPreference(String preference);
private native String nativeGetContextualSearchPreference();
@@ -1051,11 +1051,11 @@ public final class PrefServiceBridge {
private native void nativeSetSafeBrowsingEnabled(boolean enabled);
private native boolean nativeGetSafeBrowsingManaged();
private native boolean nativeGetNetworkPredictionManaged();
- private native boolean nativeNetworkPredictionEnabledHasUserSetting();
- private native boolean nativeNetworkPredictionOptionsHasUserSetting();
- private native boolean nativeGetNetworkPredictionEnabledUserPrefValue();
- private native int nativeGetNetworkPredictionOptions();
- private native void nativeSetNetworkPredictionOptions(int option);
+ private native boolean nativeObsoleteNetworkPredictionEnabledHasUserSetting();
+ private native boolean nativeObsoleteNetworkPredictionOptionsHasUserSetting();
+ private native boolean nativeObsoleteGetNetworkPredictionEnabledUserPrefValue();
+ private native boolean nativeGetNetworkPredictionEnabled();
+ private native void nativeSetNetworkPredictionEnabled(boolean enabled);
private native void nativeSetResolveNavigationErrorEnabled(boolean enabled);
private native void nativeSetEulaAccepted();
private native void nativeResetAcceptLanguages(String defaultLocale);

Powered by Google App Engine
This is Rietveld 408576698