Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/prefetch/prefetch_browsertest.cc

Issue 1712943002: [Android] Simplify "network predictions" preference to a boolean value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Dan's comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefetch/prefetch_browsertest.cc
diff --git a/chrome/browser/prefetch/prefetch_browsertest.cc b/chrome/browser/prefetch/prefetch_browsertest.cc
index fcf79080fc19f2a6335c68ff1467f10b0daf91ad..41878f1182c5318de93346386d29189bc2561ce0 100644
--- a/chrome/browser/prefetch/prefetch_browsertest.cc
+++ b/chrome/browser/prefetch/prefetch_browsertest.cc
@@ -92,8 +92,8 @@ class PrefetchBrowserTestPredictionDisabled : public PrefetchBrowserTestBase {
IN_PROC_BROWSER_TEST_F(PrefetchBrowserTestPredictionDisabled,
ExperimentDisabled) {
EXPECT_TRUE(RunPrefetchExperiment(false, browser()));
- // Should not prefetch even if preference is ALWAYS.
- SetPreference(NetworkPredictionOptions::NETWORK_PREDICTION_ALWAYS);
+ // Should not prefetch even if preference is WIFI_ONLY.
+ SetPreference(NetworkPredictionOptions::NETWORK_PREDICTION_WIFI_ONLY);
EXPECT_TRUE(RunPrefetchExperiment(false, browser()));
}
@@ -113,17 +113,6 @@ IN_PROC_BROWSER_TEST_F(PrefetchBrowserTestPrediction, PreferenceWorks) {
EXPECT_TRUE(RunPrefetchExperiment(false, browser()));
}
- // Set preference to ALWAYS: always prefetch.
newt (away) 2016/02/22 19:45:38 The "ALWAYS" state is being merged into the WIFI_O
- SetPreference(NetworkPredictionOptions::NETWORK_PREDICTION_ALWAYS);
- {
- scoped_ptr<NetworkChangeNotifier> mock(new MockNetworkChangeNotifierWIFI);
- EXPECT_TRUE(RunPrefetchExperiment(true, browser()));
- }
- {
- scoped_ptr<NetworkChangeNotifier> mock(new MockNetworkChangeNotifier4G);
- EXPECT_TRUE(RunPrefetchExperiment(true, browser()));
- }
-
// Set preference to NEVER: never prefetch.
SetPreference(NetworkPredictionOptions::NETWORK_PREDICTION_NEVER);
{

Powered by Google App Engine
This is Rietveld 408576698