Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: chrome/browser/net/prediction_options.h

Issue 1712943002: [Android] Simplify "network predictions" preference to a boolean value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Dan's comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_PREDICTION_OPTIONS_H_ 5 #ifndef CHROME_BROWSER_NET_PREDICTION_OPTIONS_H_
6 #define CHROME_BROWSER_NET_PREDICTION_OPTIONS_H_ 6 #define CHROME_BROWSER_NET_PREDICTION_OPTIONS_H_
7 7
8 namespace user_prefs { 8 namespace user_prefs {
9 class PrefRegistrySyncable; 9 class PrefRegistrySyncable;
10 } 10 }
11 11
12 class PrefService; 12 class PrefService;
13 class ProfileIOData; 13 class ProfileIOData;
14 14
15 namespace chrome_browser_net { 15 namespace chrome_browser_net {
16 16
17 // Enum describing when to allow network predictions based on connection type. 17 // Enum describing when to allow network predictions based on connection type.
18 // The numerical value is stored in the prefs file, therefore the same enum 18 // The numerical value is stored in the prefs file, therefore the same enum
19 // with the same order must be used by the platform-dependent components. 19 // with the same order must be used by the platform-dependent components.
20 enum NetworkPredictionOptions { 20 enum NetworkPredictionOptions {
21 // TODO(newt): collapse ALWAYS and WIFI_ONLY into a single value.
pasko 2016/02/25 21:43:20 nit: maybe mention crbug here as well?
newt (away) 2016/02/25 21:51:24 Done.
21 NETWORK_PREDICTION_ALWAYS, 22 NETWORK_PREDICTION_ALWAYS,
22 NETWORK_PREDICTION_WIFI_ONLY, 23 NETWORK_PREDICTION_WIFI_ONLY,
23 NETWORK_PREDICTION_NEVER, 24 NETWORK_PREDICTION_NEVER,
24 NETWORK_PREDICTION_DEFAULT = NETWORK_PREDICTION_WIFI_ONLY, 25 NETWORK_PREDICTION_DEFAULT = NETWORK_PREDICTION_WIFI_ONLY,
25 }; 26 };
26 27
27 enum class NetworkPredictionStatus { 28 enum class NetworkPredictionStatus {
28 ENABLED, 29 ENABLED,
29 DISABLED_ALWAYS, 30 DISABLED_ALWAYS,
30 DISABLED_DUE_TO_NETWORK, 31 DISABLED_DUE_TO_NETWORK,
(...skipping 17 matching lines...) Expand all
48 49
49 // To be executed on the IO thread only. 50 // To be executed on the IO thread only.
50 bool CanPreresolveAndPreconnectIO(ProfileIOData* profile_io_data); 51 bool CanPreresolveAndPreconnectIO(ProfileIOData* profile_io_data);
51 52
52 // To be executed on the UI thread only. 53 // To be executed on the UI thread only.
53 bool CanPreresolveAndPreconnectUI(PrefService* prefs); 54 bool CanPreresolveAndPreconnectUI(PrefService* prefs);
54 55
55 } // namespace chrome_browser_net 56 } // namespace chrome_browser_net
56 57
57 #endif // CHROME_BROWSER_NET_PREDICTION_OPTIONS_H_ 58 #endif // CHROME_BROWSER_NET_PREDICTION_OPTIONS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698