Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1712893002: Preallocate sample buffer to avoid resizes (Closed)

Created:
4 years, 10 months ago by mattloring
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Preallocate sample buffer to avoid resizes R=ofrobots@google.com BUG= Committed: https://crrev.com/69972208178289e567e18f40ddb32fb693e40962 Cr-Commit-Position: refs/heads/master@{#34161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/profiler/sampling-heap-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mattloring
Relies on the re-landing of https://codereview.chromium.org/1697903002/
4 years, 10 months ago (2016-02-18 23:45:51 UTC) #1
ofrobots
On 2016/02/18 23:45:51, mattloring wrote: > Relies on the re-landing of https://codereview.chromium.org/1697903002/ lgtm once prerequisite ...
4 years, 10 months ago (2016-02-19 00:22:59 UTC) #2
mattloring
4 years, 10 months ago (2016-02-19 00:27:00 UTC) #4
ulan
lgtm
4 years, 10 months ago (2016-02-19 08:49:42 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712893002/1
4 years, 10 months ago (2016-02-19 15:09:07 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 15:50:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712893002/1
4 years, 10 months ago (2016-02-19 15:55:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 15:57:47 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 15:58:15 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/69972208178289e567e18f40ddb32fb693e40962
Cr-Commit-Position: refs/heads/master@{#34161}

Powered by Google App Engine
This is Rietveld 408576698