posix/safe_strerror.cc - Issue 1712863003: Fixing clang warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: posix/safe_strerror.cc

Issue 1712863003: Fixing clang warnings. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/domokit/base@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: posix/safe_strerror.cc

diff --git a/posix/safe_strerror.cc b/posix/safe_strerror.cc

index e80e8f8bd98e2b8b7a13837b160fbc7963312845..798658e96201e3739a7de19ad8b9061b78531d1f 100644

--- a/posix/safe_strerror.cc

+++ b/posix/safe_strerror.cc

@@ -20,7 +20,11 @@

namespace base {

-#define USE_HISTORICAL_STRERRO_R (defined(__GLIBC__) || defined(OS_NACL))

+#if defined(__GLIBC__) || defined(OS_NACL)

+#define USE_HISTORICAL_STRERRO_R 1

+#else

+#define USE_HISTORICAL_STRERRO_R 0

+#endif

#if USE_HISTORICAL_STRERRO_R && defined(__GNUC__)

// GCC will complain about the unused second wrap function unless we tell it

« no previous file with comments | « no previous file | third_party/dynamic_annotations/dynamic_annotations.c » ('j') | no next file with comments »