Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1712863003: Fixing clang warnings. (Closed)

Created:
4 years, 10 months ago by Sean Klein
Modified:
4 years, 10 months ago
Reviewers:
jamesr, Petr Hosek
CC:
mojo-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/domokit/base@master
Target Ref:
refs/heads/master
Project:
mojo_base
Visibility:
Public.

Description

Fixing clang warnings. Fixed warnings caused by: -Wexpansion-to-defined and -Wconstant-conversion Files copied directly from Chromium's base. R=jamesr@chromium.org, phosek@chromium.org Committed: 82833117dada3473e590e2ecf1ba6250193e5f9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M posix/safe_strerror.cc View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/dynamic_annotations/dynamic_annotations.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sean Klein
4 years, 10 months ago (2016-02-19 01:49:40 UTC) #3
Sean Klein
4 years, 10 months ago (2016-02-19 01:49:41 UTC) #4
jamesr
lgtm
4 years, 10 months ago (2016-02-19 01:50:35 UTC) #6
Petr Hosek
4 years, 10 months ago (2016-02-19 01:54:10 UTC) #7
Petr Hosek
lgtm
4 years, 10 months ago (2016-02-19 01:54:18 UTC) #8
Sean Klein
4 years, 10 months ago (2016-02-19 01:56:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
82833117dada3473e590e2ecf1ba6250193e5f9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698