Remove mirrors in product mode

Remove mirrors in product mode

(stripped) dart_product before: 5307888
(stripped) dart_product after: 5232976

Reduction in size: 74912 bytes.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/8266501a72fd7c8e825f0af5b10d41bc744ea7fe

[Cutch, 2016-02-18 23:05:16]

Description was changed from

==========
Remove mirrors in product mode

BUG=
==========

to

==========
Remove mirrors in product mode

(stripped) dart_product before: 5307888
(stripped) dart_product after: 5232976

Reduction in size: 74912 bytes.
==========

[Cutch, 2016-02-18 23:05:16]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-02-19 01:10:58]

https://chromiumcodereview.appspot.com/1712843002/diff/1/runtime/vm/bootstrap...
File runtime/vm/bootstrap_natives.cc (right):

https://chromiumcodereview.appspot.com/1712843002/diff/1/runtime/vm/bootstrap...
runtime/vm/bootstrap_natives.cc:31: #ifndef PRODUCT
We don't also prevent the mirrors library from being registered, so we have a
library with dangling natives, which worries me. --compile_all potentially can
still find it, so we should make it constant false in product mode.

[Cutch, 2016-02-22 17:43:01]

https://chromiumcodereview.appspot.com/1712843002/diff/1/runtime/vm/bootstrap...
File runtime/vm/bootstrap_natives.cc (right):

https://chromiumcodereview.appspot.com/1712843002/diff/1/runtime/vm/bootstrap...
runtime/vm/bootstrap_natives.cc:31: #ifndef PRODUCT
On 2016/02/19 01:10:58, rmacnak wrote:
> We don't also prevent the mirrors library from being registered, so we have a
> library with dangling natives, which worries me. --compile_all potentially can
> still find it, so we should make it constant false in product mode.

I now don't register the mirrors library in product.

[rmacnak, 2016-02-22 17:48:17]

lgtm

[Cutch, 2016-02-22 17:55:25]

Description was changed from

==========
Remove mirrors in product mode

(stripped) dart_product before: 5307888
(stripped) dart_product after: 5232976

Reduction in size: 74912 bytes.
==========

to

==========
Remove mirrors in product mode

(stripped) dart_product before: 5307888
(stripped) dart_product after: 5232976

Reduction in size: 74912 bytes.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8266501a72fd7c8e825f0af5b10d41bc744ea7fe
==========

[Cutch, 2016-02-22 17:55:26]

Committed patchset #2 (id:20001) manually as
8266501a72fd7c8e825f0af5b10d41bc744ea7fe (presubmit successful).