mojo/edk/system/ports/node.cc - Issue 1712773002: Mojo: Don't allow closed pipe handles to be sent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/ports/node.cc

Issue 1712773002: Mojo: Don't allow closed pipe handles to be sent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/edk/system/ports/node.cc

diff --git a/mojo/edk/system/ports/node.cc b/mojo/edk/system/ports/node.cc

index 2ac4a204d0b2c9d1a64d0e24fa44b8974c30121b..a9b8dd04a7382cd4d0cd27768c3cfaaf9e6d841f 100644

--- a/mojo/edk/system/ports/node.cc

+++ b/mojo/edk/system/ports/node.cc

@@ -955,8 +955,9 @@ int Node::WillSendMessage_Locked(Port* port,

{

for (size_t i = 0; i < message->num_ports(); ++i) {

ports[i] = GetPort_Locked(message->ports()[i]);

- ports[i]->lock.Acquire();

+ CHECK(ports[i]);

+ ports[i]->lock.Acquire();

int error = OK;

if (ports[i]->state != Port::kReceiving)

error = ERROR_PORT_STATE_UNEXPECTED;