Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1712773002: Mojo: Don't allow closed pipe handles to be sent (Closed)

Created:
4 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 10 months ago
Reviewers:
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: Don't allow closed pipe handles to be sent Ports need to be sent, but a closed pipe's port no longer exists. Sending a closed port = crashy times. This should be prevented at the EDK layer where message serialization can be sanely rejected. So do that. This also adds a few CHECKS to help clarify other potential crashes. BUG=587937 TBR=amistry@chromium.org Committed: https://crrev.com/f44ffa817c0fffc2e7bb6c8bdcaf41e203a58d8a Cr-Commit-Position: refs/heads/master@{#376392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/ports/node.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/remote_message_pipe_bootstrap.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712773002/1
4 years, 10 months ago (2016-02-18 20:49:40 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/23957)
4 years, 10 months ago (2016-02-18 21:42:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712773002/1
4 years, 10 months ago (2016-02-19 04:23:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 05:08:09 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 05:10:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f44ffa817c0fffc2e7bb6c8bdcaf41e203a58d8a
Cr-Commit-Position: refs/heads/master@{#376392}

Powered by Google App Engine
This is Rietveld 408576698