GrAuditTrail can now be enabled/disabled at runtime

GrAuditTrail can now be enabled/disabled at runtime
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1712753002

TBR=bsalomon@google.com
Doesn't actually change the public API

Committed: https://skia.googlesource.com/skia/+/c85d9fbc0adacc9acb9faa3fe107652f0d76760a

[ethannicholas, 2016-02-18 20:34:53]

Description was changed from

==========
GrAuditTrail can now be enabled/disabled at runtime
==========

to

==========
GrAuditTrail can now be enabled/disabled at runtime
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ethannicholas, 2016-02-18 20:41:29]

ethannicholas@google.com changed reviewers:
+ jcgregorio@google.com, joshualitt@google.com

[ethannicholas, 2016-02-18 20:41:30]

The issue we were seeing with breakpoints taking forever turned out to be due to
GrAuditTrail. Since it was always on, every single draw was generating an audit
trail. The entire trail, spanning potentially many thousands of draws as various
PNGs got generated, was then erroneously attached to the next JSON we generated.
Breakpoints were the unlucky trigger, as they moved into a new block of draw
commands, causing a request which had the server spend a couple of minutes
generating massive amounts of JSON.

The fix is to make GrAuditTrail enableable / disableable at runtime, and then be
more judicious in our handling of the audit trail.

[joshualitt, 2016-02-18 20:48:11]

On 2016/02/18 20:41:30, ethannicholas wrote:
> The issue we were seeing with breakpoints taking forever turned out to be due
to
> GrAuditTrail. Since it was always on, every single draw was generating an
audit
> trail. The entire trail, spanning potentially many thousands of draws as
various
> PNGs got generated, was then erroneously attached to the next JSON we
generated.
> Breakpoints were the unlucky trigger, as they moved into a new block of draw
> commands, causing a request which had the server spend a couple of minutes
> generating massive amounts of JSON.
> 
> The fix is to make GrAuditTrail enableable / disableable at runtime, and then
be
> more judicious in our handling of the audit trail.

given the consequences of leaving this enabled(SORRY), do we want an AutoEnable
which uses constructor / destructor?

[ethannicholas, 2016-02-18 20:59:49]

On 2016/02/18 20:48:11, joshualitt wrote:
> On 2016/02/18 20:41:30, ethannicholas wrote:
> > The issue we were seeing with breakpoints taking forever turned out to be
due
> to
> > GrAuditTrail. Since it was always on, every single draw was generating an
> audit
> > trail. The entire trail, spanning potentially many thousands of draws as
> various
> > PNGs got generated, was then erroneously attached to the next JSON we
> generated.
> > Breakpoints were the unlucky trigger, as they moved into a new block of draw
> > commands, causing a request which had the server spend a couple of minutes
> > generating massive amounts of JSON.
> > 
> > The fix is to make GrAuditTrail enableable / disableable at runtime, and
then
> be
> > more judicious in our handling of the audit trail.
> 
> given the consequences of leaving this enabled(SORRY), do we want an
AutoEnable
> which uses constructor / destructor?

Good suggestion, done :-)

[joshualitt, 2016-02-18 21:01:13]

On 2016/02/18 20:59:49, ethannicholas wrote:
> On 2016/02/18 20:48:11, joshualitt wrote:
> > On 2016/02/18 20:41:30, ethannicholas wrote:
> > > The issue we were seeing with breakpoints taking forever turned out to be
> due
> > to
> > > GrAuditTrail. Since it was always on, every single draw was generating an
> > audit
> > > trail. The entire trail, spanning potentially many thousands of draws as
> > various
> > > PNGs got generated, was then erroneously attached to the next JSON we
> > generated.
> > > Breakpoints were the unlucky trigger, as they moved into a new block of
draw
> > > commands, causing a request which had the server spend a couple of minutes
> > > generating massive amounts of JSON.
> > > 
> > > The fix is to make GrAuditTrail enableable / disableable at runtime, and
> then
> > be
> > > more judicious in our handling of the audit trail.
> > 
> > given the consequences of leaving this enabled(SORRY), do we want an
> AutoEnable
> > which uses constructor / destructor?
> 
> Good suggestion, done :-)

lgtm, but may want to leave a comment about the importance of enabling /
disabling and reseting this class

[ethannicholas, 2016-02-18 21:04:52]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2016-02-18 21:04:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1712753002/#ps60001
(title: "more comment")

[commit-bot: I haz the power, 2016-02-18 21:04:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1712753002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1712753002/60001

[commit-bot: I haz the power, 2016-02-18 21:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 21:06:26]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[ethannicholas, 2016-02-18 21:08:26]

Description was changed from

==========
GrAuditTrail can now be enabled/disabled at runtime
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
GrAuditTrail can now be enabled/disabled at runtime
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com
Doesn't actually change the public API
==========

[ethannicholas, 2016-02-18 21:08:36]

The CQ bit was checked by ethannicholas@google.com

[commit-bot: I haz the power, 2016-02-18 21:08:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1712753002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1712753002/60001

[commit-bot: I haz the power, 2016-02-18 21:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 21:10:26]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[ethannicholas, 2016-02-18 21:13:37]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2016-02-18 21:13:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1712753002/#ps80001
(title: "removed one more reference to GR_BATCH_DEBUGGING_OUTPUT")

[commit-bot: I haz the power, 2016-02-18 21:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1712753002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1712753002/80001

[commit-bot: I haz the power, 2016-02-18 21:45:43]

Description was changed from

==========
GrAuditTrail can now be enabled/disabled at runtime
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com
Doesn't actually change the public API
==========

to

==========
GrAuditTrail can now be enabled/disabled at runtime
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com
Doesn't actually change the public API

Committed:
https://skia.googlesource.com/skia/+/c85d9fbc0adacc9acb9faa3fe107652f0d76760a
==========

[commit-bot: I haz the power, 2016-02-18 21:45:44]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/c85d9fbc0adacc9acb9faa3fe107652f0d76760a