Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4488)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc

Issue 17127002: Correctly integrate StoragePartition into TestingProfile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments. merge to ToT. Murder a DB thread and more TestBrowserThreads. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/managed_mode/managed_user_refresh_token_fetcher_unittest.cc ('k') | chrome/browser/page_cycler/page_cycler_unittest.cc » ('j') | chrome/browser/password_manager/password_store_x_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc
diff --git a/chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc b/chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc
index 284d34b5d220defb6907aa7c773b0b77b94eb264..baf230f52c4996e9c9e18b504096e3d0be093472 100644
--- a/chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc
+++ b/chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc
@@ -8,10 +8,10 @@
#include <string>
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop.h"
#include "chrome/browser/net/gaia/gaia_oauth_consumer.h"
#include "chrome/browser/net/gaia/gaia_oauth_fetcher.h"
#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "google_apis/gaia/gaia_constants.h"
#include "google_apis/gaia/gaia_urls.h"
#include "google_apis/gaia/google_service_auth_error.h"
@@ -123,7 +123,10 @@ TEST(GaiaOAuthFetcherTest, GetOAuthToken) {
}
#endif // 0 // Suppressing for now
-typedef testing::Test GaiaOAuthFetcherTest;
+class GaiaOAuthFetcherTest : public testing::Test {
+ private:
+ content::TestBrowserThreadBundle thread_bundle_;
+};
TEST_F(GaiaOAuthFetcherTest, OAuthGetAccessToken) {
const std::string oauth_token =
« no previous file with comments | « chrome/browser/managed_mode/managed_user_refresh_token_fetcher_unittest.cc ('k') | chrome/browser/page_cycler/page_cycler_unittest.cc » ('j') | chrome/browser/password_manager/password_store_x_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698