chrome/browser/sync/profile_sync_service_typed_url_unittest.cc - Issue 17127002: Correctly integrate StoragePartition into TestingProfile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

Issue 17127002: Correctly integrate StoragePartition into TestingProfile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments. merge to ToT. Murder a DB thread and more TestBrowserThreads. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

index 9d4cbe7a498bd1d71af336778d12c0c753774ccf..05028cbdfd251c2a2f91098b5eec149081991200 100644

--- a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

@@ -184,8 +184,7 @@ class ProfileSyncServiceTypedUrlTest : public AbstractProfileSyncServiceTest {

virtual void SetUp() {

AbstractProfileSyncServiceTest::SetUp();

- profile_.reset(new ProfileMock);

- profile_->CreateRequestContext();

+ profile_.reset(new ProfileMock());

invalidation::InvalidationServiceFactory::GetInstance()->

SetBuildOnlyFakeInvalidatorsForTest(true);

history_backend_ = new HistoryBackendMock();

@@ -202,7 +201,6 @@ class ProfileSyncServiceTypedUrlTest : public AbstractProfileSyncServiceTest {

EXPECT_CALL((*history_service_), Shutdown())

.WillOnce(ShutdownHistoryService(history_thread_.release(),

history_service_));

- profile_->ResetRequestContext();

profile_.reset();

AbstractProfileSyncServiceTest::TearDown();

}