Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc

Issue 17127002: Correctly integrate StoragePartition into TestingProfile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup TODOs. merge code. kill more threads. i never get tired of thread carnage. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
diff --git a/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc b/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
index 755221ca4c93002040e2633485fc8fcc324cfb18..1f97911304396b7c5c3c147c825362d196547f72 100644
--- a/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
+++ b/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
@@ -81,9 +81,7 @@ class WalletSigninHelperForTesting : public WalletSigninHelper {
} // namespace
class WalletSigninHelperTest : public testing::Test {
- public:
- WalletSigninHelperTest() {}
-
+ protected:
virtual void SetUp() OVERRIDE {
signin_helper_.reset(new WalletSigninHelperForTesting(
&mock_delegate_,
@@ -95,7 +93,6 @@ class WalletSigninHelperTest : public testing::Test {
signin_helper_.reset();
}
- protected:
// Sets up a response for the mock URLFetcher and completes the request.
void SetUpFetcherResponseAndCompleteRequest(
const std::string& url,
@@ -191,8 +188,9 @@ class WalletSigninHelperTest : public testing::Test {
content::TestBrowserContext browser_context_;
private:
- net::TestURLFetcherFactory factory_;
+ // The profile's request context must be released on the IO thread.
content::TestBrowserThreadBundle thread_bundle_;
+ net::TestURLFetcherFactory factory_;
};
TEST_F(WalletSigninHelperTest, PassiveSigninSuccessful) {

Powered by Google App Engine
This is Rietveld 408576698