Correctly integrate StoragePartition into TestingProfile.

chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/spelling_menu_observer.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
@@ skipping 44 matching lines @@
                           const string16& label,
                           ui::MenuModel* model) OVERRIDE;
   virtual void UpdateMenuItem(int command_id,
                               bool enabled,
                               bool hidden,
                               const string16& title) OVERRIDE;
   virtual RenderViewHost* GetRenderViewHost() const OVERRIDE;
   virtual WebContents* GetWebContents() const OVERRIDE;
   virtual Profile* GetProfile() const OVERRIDE;
 
-  // Create a testing URL request context.
-  void CreateRequestContext() {
-    profile_->CreateRequestContext();
-  }
-
   // Attaches a RenderViewContextMenuObserver to be tested.
   void SetObserver(RenderViewContextMenuObserver* observer);
 
   // Returns the number of items added by the test.
   size_t GetMenuSize() const;
 
   // Returns the i-th item.
   bool GetMenuItem(size_t i, MockMenuItem* item) const;
 
   // Returns the writable profile used in this test.
@@ skipping 240 matching lines @@
   EXPECT_FALSE(item.hidden);
 }
 
 // Test that there will be a separator after "no suggestions" if
 // SpellingServiceClient::SUGGEST is on.
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, SeparatorAfterSuggestions) {
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   command_line->AppendSwitch(switches::kUseSpellingSuggestions);
 
-  // Make sure we can pretend to handle the JSON request.
-  menu()->CreateRequestContext();
-
   // Force a non-empty locale so SUGGEST is available.
   menu()->GetPrefs()->SetString(prefs::kSpellCheckDictionary, "en");
   EXPECT_TRUE(SpellingServiceClient::IsAvailable(menu()->GetProfile(),
     SpellingServiceClient::SUGGEST));
 
   InitMenu("jhhj", NULL);
 
   // The test should see a top separator, "No spelling suggestions",
   // "No more Google suggestions" (from SpellingService) and a separator
   // as the first four items, then possibly more (not relevant here).
@@ skipping 20 matching lines @@
   EXPECT_FALSE(item.enabled);
   EXPECT_FALSE(item.hidden);
 }
 
 // Test that we don't show "No more suggestions from Google" if the spelling
 // service is enabled and that there is only one suggestion.
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
                        NoMoreSuggestionsNotDisplayed) {
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
 
-  // Make sure we can pretend to handle the JSON request.
-  menu()->CreateRequestContext();
-
   // Force a non-empty locale so SPELLCHECK is available.
   menu()->GetPrefs()->SetString(prefs::kSpellCheckDictionary, "en");
   EXPECT_TRUE(SpellingServiceClient::IsAvailable(menu()->GetProfile(),
     SpellingServiceClient::SPELLCHECK));
   InitMenu("asdfkj", "asdf");
 
   // The test should see a separator, a suggestion and another separator
   // as the first two items, then possibly more (not relevant here).
   EXPECT_LT(3U, menu()->GetMenuSize());
 
@@ skipping 85 matching lines @@
   EXPECT_LT(static_cast<size_t>(5), menu()->GetMenuSize());
   // This test only cares that the first one is a separator.
   menu()->GetMenuItem(0, &item);
   EXPECT_EQ(-1, item.command_id);
 
   // Case #3. Misspelled word, suggestion service is on.
   Reset();
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   command_line->AppendSwitch(switches::kUseSpellingSuggestions);
-  menu()->CreateRequestContext();
   InitMenu("asdfkj", NULL);
 
   // Should have at least 2 entries. Separator, suggestion.
   EXPECT_LT(2U, menu()->GetMenuSize());
   menu()->GetMenuItem(0, &item);
   EXPECT_EQ(-1, item.command_id);
   menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION, item.command_id);
 }