device/bluetooth/bluetooth_gatt_characteristic_unittest.cc - Issue 1712593002: bluetooth: android: Confirm the notify session after the descriptor has been written.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_gatt_characteristic_unittest.cc

Issue 1712593002: bluetooth: android: Confirm the notify session after the descriptor has been written. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Vincent's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluetooth_gatt_characteristic.cc ('K') | « device/bluetooth/bluetooth_gatt_characteristic.cc ('k') | device/bluetooth/bluetooth_gatt_descriptor_unittest.cc » ('j') | device/bluetooth/bluetooth_gatt_descriptor_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_gatt_characteristic_unittest.cc

diff --git a/device/bluetooth/bluetooth_gatt_characteristic_unittest.cc b/device/bluetooth/bluetooth_gatt_characteristic_unittest.cc

index e8cfe8777287796e9be40b8d5502bc62d9bb753b..73983c344e5b0e24bbceec7d5705a098a3c11602 100644

--- a/device/bluetooth/bluetooth_gatt_characteristic_unittest.cc

+++ b/device/bluetooth/bluetooth_gatt_characteristic_unittest.cc

@@ -874,14 +874,7 @@ TEST_F(BluetoothGattCharacteristicTest, StartNotifySession_Multiple) {

characteristic1_->StartNotifySession(

GetNotifyCallback(Call::EXPECTED),

GetGattErrorCallback(Call::NOT_EXPECTED));

-#if defined(OS_ANDROID)

- // TODO(crbug.com/551634): Decide when implementing IsNotifying if Android

- // should trust the notification request always worked, or if we should always

- // redundantly set the value to the OS.

- EXPECT_EQ(2, gatt_notify_characteristic_attempts_);

-#else

EXPECT_EQ(1, gatt_notify_characteristic_attempts_);

-#endif

EXPECT_EQ(0, callback_count_);

SimulateGattNotifySessionStarted(characteristic1_);

EXPECT_EQ(2, callback_count_);