Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1712583004: Test and fix resynthesis of generic closures. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reference bug from TODO comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -22 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +42 lines, -22 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-19 18:07:09 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-19 18:11:47 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-19 18:33:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
677c01e88b4257722a9401522eface5946c44570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698