Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1712563006: Cleanup access to guarded_fields (Closed)

Created:
4 years, 10 months ago by srdjan
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -43 lines) Patch
M runtime/vm/compiler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph.h View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 10 months ago (2016-02-19 18:54:04 UTC) #2
Florian Schneider
Lgtm
4 years, 10 months ago (2016-02-19 18:57:09 UTC) #3
srdjan
4 years, 10 months ago (2016-02-19 19:07:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c77e70b490350e59faa83e67e074cfe5293b287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698