Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1712563004: Move SkTInternalLList.h to src/core. (Closed)

Created:
4 years, 10 months ago by bungeman-skia
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkTInternalLList.h to src/core. TBR=reed Not intended for external use. Committed: https://skia.googlesource.com/skia/+/d689bf874826d38c6ef0d8b802b74d61fab5ec2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -272 lines) Patch
M gyp/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
D include/core/SkTInternalLList.h View 1 chunk +0 lines, -272 lines 0 comments Download
A + src/core/SkTInternalLList.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712563004/1
4 years, 10 months ago (2016-02-18 19:29:00 UTC) #4
bungeman-skia
Seems we have both SkTInternalLList and SkTLList. Making this private makes it easier to potentially ...
4 years, 10 months ago (2016-02-18 19:33:37 UTC) #6
mtklein
lgtm
4 years, 10 months ago (2016-02-18 19:36:04 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 19:50:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712563004/1
4 years, 10 months ago (2016-02-18 19:52:33 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 19:53:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d689bf874826d38c6ef0d8b802b74d61fab5ec2f

Powered by Google App Engine
This is Rietveld 408576698