Issue 171253004: Fix for issue 16967

Issue 171253004: Fix for issue 16967 (Closed)

Created:
6 years, 10 months ago by sra1

Modified:
6 years, 10 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for issue 16967 R=floitsch@google.com, ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=32861

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
	A	tests/compiler/dart2js_extra/16967_test.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/171253004/diff/10001/sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart File sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (right): https://codereview.chromium.org/171253004/diff/10001/sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart#newcode130 sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:130: // Widen any int subclass to full integer. ...

6 years, 10 months ago (2014-02-20 08:19:13 UTC) #2

sra1

Committed patchset #2 manually as r32861 (presubmit successful).

6 years, 10 months ago (2014-02-20 19:02:15 UTC) #4

sra1

6 years, 10 months ago (2014-02-20 19:02:25 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/171253004/diff/10001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart
(right):

https://codereview.chromium.org/171253004/diff/10001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:130: //
Widen any int subclass to full integer.
On 2014/02/20 08:19:13, ngeoffray wrote:
> Maybe add that this is necessary because we have types that represent positive
> integers.

Done.

Expand Messages | Collapse Messages