Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 171253002: linux_aura: Bubbles should release their lock on disable_inactive_rendering. (Closed)

Created:
6 years, 10 months ago by Elliot Glaysher
Modified:
6 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina
Visibility:
Public.

Description

linux_aura: Bubbles should release their lock on disable_inactive_rendering. When opening a bubble on linux aura, we send a message to our anchor Widget telling it to not render as if it was disabled. We never reenable this when we go away. BUG=342008 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/views/bubble/bubble_delegate.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
lgtm
6 years, 10 months ago (2014-02-18 20:57:35 UTC) #1
Elliot Glaysher
Please review, msw (ignore my above mistake!)
6 years, 10 months ago (2014-02-18 20:58:21 UTC) #2
msw
LGTM. I patched this in to make sure the browser frame didn't flicker to inactive ...
6 years, 10 months ago (2014-02-18 21:10:57 UTC) #3
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 10 months ago (2014-02-18 21:14:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/171253002/1
6 years, 10 months ago (2014-02-18 21:14:51 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 23:59:29 UTC) #6
Message was sent while issue was closed.
Change committed as 251883

Powered by Google App Engine
This is Rietveld 408576698