Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 1712363002: Revert of DevTools: improve SCSS parser to correctly handle variable expansions (Closed)

Created:
4 years, 10 months ago by imcheng
Modified:
4 years, 10 months ago
Reviewers:
dgozman, lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: improve SCSS parser to correctly handle variable expansions (patchset #1 id:1 of https://codereview.chromium.org/1713783003/ ) Reason for revert: Broke WebKit Linux webkit_tests: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/60992 Original issue's description: > DevTools: improve SCSS parser to correctly handle variable expansions > > The patch improves SCSS parser to not get stuck after encountering > variable expansion. > > BUG=527993 > R=pfeldman, dgozman > > Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 > Cr-Commit-Position: refs/heads/master@{#376489} TBR=dgozman@chromium.org,pfeldman@chromium.org,lushnikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527993 Committed: https://crrev.com/24be28378f000902405acae20cf94b2df392151d Cr-Commit-Position: refs/heads/master@{#376533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -81 lines) Patch
D third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
imcheng
Created Revert of DevTools: improve SCSS parser to correctly handle variable expansions
4 years, 10 months ago (2016-02-19 21:05:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712363002/1
4 years, 10 months ago (2016-02-19 21:07:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 21:10:24 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 21:11:19 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24be28378f000902405acae20cf94b2df392151d
Cr-Commit-Position: refs/heads/master@{#376533}

Powered by Google App Engine
This is Rietveld 408576698