Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 171233015: Fix NaCl build for pepper_32 (Closed)

Created:
6 years, 10 months ago by borenet
Modified:
6 years, 10 months ago
Reviewers:
rmistry, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix NaCl build for pepper_32 BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M gyp/common_conditions.gypi View 2 chunks +7 lines, -0 lines 0 comments Download
M platform_tools/nacl/nacl_make View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
6 years, 10 months ago (2014-02-20 19:15:06 UTC) #1
djsollen
lgtm from a script perspective
6 years, 10 months ago (2014-02-20 19:25:31 UTC) #2
rmistry
LGTM
6 years, 10 months ago (2014-02-20 19:55:47 UTC) #3
borenet
The CQ bit was checked by borenet@google.com
6 years, 10 months ago (2014-02-20 20:33:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/171233015/1
6 years, 10 months ago (2014-02-20 20:36:51 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 00:40:20 UTC) #6
Message was sent while issue was closed.
Change committed as 13523

Powered by Google App Engine
This is Rietveld 408576698